You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pradeep Soundararajan <pr...@citrix.com> on 2013/03/15 12:34:07 UTC

Review Request: BUG-ID: CLOUDSTACK-1689

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/
-----------------------------------------------------------

Review request for cloudstack, David Nalley, Hugo Trippaers, Wido den Hollander, and Noa Resare.


Description
-------

BUG-ID: CLOUDSTACK-1689

Summary: KVM agent install.sh should install ipset command

Added ipset in cloud.spec as part of agent install.

Signed-off-by: Pradeep <pr...@citrix.com>


Diffs
-----

  packaging/centos63/cloud.spec 1b2c9a9633e161081809c3aa25574fdb863d4d0b 

Diff: https://reviews.apache.org/r/9946/diff/


Testing
-------

Packaging ipset properly after this change. 


Thanks,

Pradeep Soundararajan

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by Chip Childers <ch...@sungard.com>.
On Mon, Apr 01, 2013 at 07:51:20AM +0000, Pradeep Soundararajan wrote:
> 
> 
> > On March 29, 2013, 12:46 p.m., ASF Subversion and Git Services wrote:
> > > Commit 5a66ec35ad08ff3313e72b54eba7e1754868eee4 in branch refs/heads/bvt from Prasanna Santhanam <ts...@apache.org>
> > > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5a66ec3 ]
> > > 
> > > CLOUDSTACK-1689: KVM agent install.sh should install ipset command
> > > 
> > > Added ipset in cloud.spec as part of agent install.
> > > 
> > > Signed-off-by: Pradeep <pr...@citrix.com>
> > > Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> > >
> 
> I hope I have added as part of debian agent install. 
> 
> Chip, please review this https://reviews.apache.org/r/10216 
> 
> 
> - Pradeep


ACK - and done.

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by Pradeep Soundararajan <pr...@citrix.com>.

> On March 29, 2013, 12:46 p.m., ASF Subversion and Git Services wrote:
> > Commit 5a66ec35ad08ff3313e72b54eba7e1754868eee4 in branch refs/heads/bvt from Prasanna Santhanam <ts...@apache.org>
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5a66ec3 ]
> > 
> > CLOUDSTACK-1689: KVM agent install.sh should install ipset command
> > 
> > Added ipset in cloud.spec as part of agent install.
> > 
> > Signed-off-by: Pradeep <pr...@citrix.com>
> > Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> >

I hope I have added as part of debian agent install. 

Chip, please review this https://reviews.apache.org/r/10216 


- Pradeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18508
-----------------------------------------------------------


On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 10:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1689
> 
> Summary: KVM agent install.sh should install ipset command
> 
> Added ipset in cloud.spec as part of agent install.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec e10ae1e 
> 
> Diff: https://reviews.apache.org/r/9946/diff/
> 
> 
> Testing
> -------
> 
> Packaging ipset properly after this change. 
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18508
-----------------------------------------------------------


Commit 5a66ec35ad08ff3313e72b54eba7e1754868eee4 in branch refs/heads/bvt from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5a66ec3 ]

CLOUDSTACK-1689: KVM agent install.sh should install ipset command

Added ipset in cloud.spec as part of agent install.

Signed-off-by: Pradeep <pr...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 10:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1689
> 
> Summary: KVM agent install.sh should install ipset command
> 
> Added ipset in cloud.spec as part of agent install.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec e10ae1e 
> 
> Diff: https://reviews.apache.org/r/9946/diff/
> 
> 
> Testing
> -------
> 
> Packaging ipset properly after this change. 
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18585
-----------------------------------------------------------


Commit 9eed6586092d4ecd268d403f1fec83ad196569b4 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9eed658 ]

CLOUDSTACK-1689: Adding ipset as part of agent install for debian
Signed-off-by: Chip Childers <ch...@gmail.com>


- ASF Subversion and Git Services


On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 10:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1689
> 
> Summary: KVM agent install.sh should install ipset command
> 
> Added ipset in cloud.spec as part of agent install.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec e10ae1e 
> 
> Diff: https://reviews.apache.org/r/9946/diff/
> 
> 
> Testing
> -------
> 
> Packaging ipset properly after this change. 
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18506
-----------------------------------------------------------


Commit 5a66ec35ad08ff3313e72b54eba7e1754868eee4 in branch refs/heads/master from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5a66ec3 ]

CLOUDSTACK-1689: KVM agent install.sh should install ipset command

Added ipset in cloud.spec as part of agent install.

Signed-off-by: Pradeep <pr...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 10:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1689
> 
> Summary: KVM agent install.sh should install ipset command
> 
> Added ipset in cloud.spec as part of agent install.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec e10ae1e 
> 
> Diff: https://reviews.apache.org/r/9946/diff/
> 
> 
> Testing
> -------
> 
> Packaging ipset properly after this change. 
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18507
-----------------------------------------------------------

Ship it!


Ship It!

- Hugo Trippaers


On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 10:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1689
> 
> Summary: KVM agent install.sh should install ipset command
> 
> Added ipset in cloud.spec as part of agent install.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec e10ae1e 
> 
> Diff: https://reviews.apache.org/r/9946/diff/
> 
> 
> Testing
> -------
> 
> Packaging ipset properly after this change. 
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18505
-----------------------------------------------------------


Commit fa47d30866f17201a74ec145c96c9bd79b022887 in branch refs/heads/4.1 from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fa47d30 ]

CLOUDSTACK-1689: KVM agent install.sh should install ipset command

Added ipset in cloud.spec as part of agent install.

Signed-off-by: Pradeep <pr...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 10:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1689
> 
> Summary: KVM agent install.sh should install ipset command
> 
> Added ipset in cloud.spec as part of agent install.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec e10ae1e 
> 
> Diff: https://reviews.apache.org/r/9946/diff/
> 
> 
> Testing
> -------
> 
> Packaging ipset properly after this change. 
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/#review18586
-----------------------------------------------------------


Commit 6eac4229434b46ee74b5952d3abd26b646166b39 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6eac422 ]

CLOUDSTACK-1689: Adding ipset as part of agent install for debian
Signed-off-by: Chip Childers <ch...@gmail.com>


- ASF Subversion and Git Services


On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9946/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 10:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1689
> 
> Summary: KVM agent install.sh should install ipset command
> 
> Added ipset in cloud.spec as part of agent install.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec e10ae1e 
> 
> Diff: https://reviews.apache.org/r/9946/diff/
> 
> 
> Testing
> -------
> 
> Packaging ipset properly after this change. 
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>

Re: Review Request: BUG-ID: CLOUDSTACK-1689

Posted by Pradeep Soundararajan <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9946/
-----------------------------------------------------------

(Updated March 29, 2013, 10:41 a.m.)


Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander.


Changes
-------

I have noticed this patch has not been applied. Please apply it.


Description
-------

BUG-ID: CLOUDSTACK-1689

Summary: KVM agent install.sh should install ipset command

Added ipset in cloud.spec as part of agent install.

Signed-off-by: Pradeep <pr...@citrix.com>


Diffs (updated)
-----

  packaging/centos63/cloud.spec e10ae1e 

Diff: https://reviews.apache.org/r/9946/diff/


Testing
-------

Packaging ipset properly after this change. 


Thanks,

Pradeep Soundararajan