You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@quickstep.apache.org by sh...@apache.org on 2016/06/28 17:43:53 UTC
[3/4] incubator-quickstep git commit: Added move semantic in the
constructor of window plan
Added move semantic in the constructor of window plan
Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/cfc89d65
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/cfc89d65
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/cfc89d65
Branch: refs/heads/move-semantic-in-window-plan
Commit: cfc89d65a77e43d2b2095f8c9db62baf8922f8b8
Parents: 79b1014
Author: shixuan-fan <sh...@apache.org>
Authored: Tue Jun 28 15:42:09 2016 +0000
Committer: shixuan-fan <sh...@apache.org>
Committed: Tue Jun 28 15:42:09 2016 +0000
----------------------------------------------------------------------
query_optimizer/resolver/Resolver.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/cfc89d65/query_optimizer/resolver/Resolver.cpp
----------------------------------------------------------------------
diff --git a/query_optimizer/resolver/Resolver.cpp b/query_optimizer/resolver/Resolver.cpp
index 1eb6d86..95096c9 100644
--- a/query_optimizer/resolver/Resolver.cpp
+++ b/query_optimizer/resolver/Resolver.cpp
@@ -228,9 +228,9 @@ struct Resolver::QueryAggregationInfo {
};
struct Resolver::WindowPlan {
- WindowPlan(const E::WindowInfo &window_info_in,
+ WindowPlan(E::WindowInfo &&window_info_in,
const L::LogicalPtr &logical_plan_in)
- : window_info(window_info_in),
+ : window_info(std::move(window_info_in)),
logical_plan(logical_plan_in) {}
const E::WindowInfo window_info;
@@ -1032,7 +1032,7 @@ L::LogicalPtr Resolver::resolveSelect(
L::LogicalPtr sorted_logical_plan = resolveSortInWindow(logical_plan,
resolved_window);
- WindowPlan window_plan(resolved_window, sorted_logical_plan);
+ WindowPlan window_plan(std::move(resolved_window), sorted_logical_plan);
sorted_window_map.emplace(window.name()->value(), window_plan);
}