[jira] [Updated] (DERBY-3331) UCS_BASIC class, SQLChar, is doing territory based related work. It would be good to move this code into territry based classes.

["Mamta A. Satoor (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mamta A. Satoor updated DERBY-3331:
-----------------------------------

    Urgency: Low
     Labels: derby_triage10_11  (was: )
    
> UCS_BASIC class, SQLChar, is doing territory based related work. It would be good to move this code into territry based classes.
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3331
>                 URL: https://issues.apache.org/jira/browse/DERBY-3331
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.3.3.0, 10.4.1.3
>            Reporter: Mamta A. Satoor
>              Labels: derby_triage10_11
>
> SQLChar has a method called getCollationKey which gets called by territory sensitive class, WorkHorseForCollator. The code inside getCollationKey uses Collator to get the collation key for the string. This will never apply for UCS_BASIC class and hence this Collator specific code should be in territory sensitive classes. 
> Also, getCollationKey in SQLChar uses getCollatorForCollation method to get access to Collator object. Because of this requirement, SQLChar has to implement getCollatorForCollation method which in theory will never get called for UCS_BASIC characters. I think all this is a cause of confusion for a future developer who might be looking at this code. Until the final solution is derived, in the interim, we should definitely atleast have an ASSERT in getCollatorForCollation method in SQLChar to ensure that it is never getting called when dealing with UCS_BASIC characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira