You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Lance Weber (JIRA)" <ji...@apache.org> on 2009/09/02 22:14:33 UTC
[jira] Created: (CASSANDRA-416) modify cassandra.in.sh to only set
$CASSANDRA_CONF if it is not already set
modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
---------------------------------------------------------------------------
Key: CASSANDRA-416
URL: https://issues.apache.org/jira/browse/CASSANDRA-416
Project: Cassandra
Issue Type: Improvement
Affects Versions: 0.4
Environment: unix/linux
Reporter: Lance Weber
Fix For: 0.5
modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-416) modify cassandra.in.sh to only
set $CASSANDRA_CONF if it is not already set
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750674#action_12750674 ]
Eric Evans commented on CASSANDRA-416:
--------------------------------------
Could you elaborate a little about the problem you're trying to solve here?
The reason I ask:
cassandra.in.sh is meant as a sort of configuration for the startup script (bin/cassandra), and it's pretty much a given that any serious use will require you to edit it or create your own (though the defaults in bin/cassandra.in.sh are meant to be close enough that they should work for a first-test).
Even when running from an SVN checkout, you can run a customized version of cassandra.in.sh (for example to use an alternate CASSANDRA_CONF) by doing something like...
CASSANDRA_INCLUDE=~/.cassandra.in.sh bin/cassandra -f
You could even omit CASSANDRA_CONF entirely from your CASSANDRA_INCLUDE and pass it along in the environment separately.
So, to summarize, I'm thinking that a) this shouldn't be needed, and that b) it might give people the impression that we're expecting them to use an unaltered CASSANDRA_INCLUDE and to set CASSANDRA_CONF, which isn't currently the case.
Also, all of this would similarly apply to CLASSPATH and JVM_OPTS.
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-416) modify cassandra.in.sh to only set
$CASSANDRA_CONF if it is not already set
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans resolved CASSANDRA-416.
----------------------------------
Resolution: Fixed
Assignee: Eric Evans
Committed. Thanks for the report.
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt, v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-416) modify cassandra.in.sh to only set
$CASSANDRA_CONF if it is not already set
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-416:
---------------------------------
Attachment: v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt, v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-416) modify cassandra.in.sh to only set
$CASSANDRA_CONF if it is not already set
Posted by "Lance Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lance Weber updated CASSANDRA-416:
----------------------------------
Priority: Trivial (was: Major)
Affects Version/s: (was: 0.4)
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-416) modify cassandra.in.sh to only
set $CASSANDRA_CONF if it is not already set
Posted by "Lance Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750787#action_12750787 ]
Lance Weber commented on CASSANDRA-416:
---------------------------------------
+1 Thanks!
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt, v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-416) modify cassandra.in.sh to only
set $CASSANDRA_CONF if it is not already set
Posted by "Lance Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750690#action_12750690 ]
Lance Weber commented on CASSANDRA-416:
---------------------------------------
Until configuration management is rehauled, I'm just looking to make a things easier for user-developers who are trying to stay somewhat current and who do not want to incur a ton of update pain when checking out cass updates locally. This is a pretty minor change that allows us to decouple local configuration settings from the cass code base without having to diff cassandra.in.sh to see if there are new settings being recommended. If we aren't supposed to be using cassandra.in.sh then there should probably be documentation that effect.
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-416) modify cassandra.in.sh to only
set $CASSANDRA_CONF if it is not already set
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750786#action_12750786 ]
Jonathan Ellis commented on CASSANDRA-416:
------------------------------------------
+1
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt, v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-416) modify cassandra.in.sh to only set
$CASSANDRA_CONF if it is not already set
Posted by "Lance Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lance Weber updated CASSANDRA-416:
----------------------------------
Attachment: cass_conf-patch.txt
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-416) modify cassandra.in.sh to only
set $CASSANDRA_CONF if it is not already set
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750784#action_12750784 ]
Eric Evans commented on CASSANDRA-416:
--------------------------------------
As discussed on IRC, the configuration aspect of this is in fact decoupled, and folks *are* encouraged to edit cassandra.in.sh as needed.
The attached patch (v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt) should make it even easier to use customized values without locally modifying the include (ala a ~/.cassandra.in.sh), and adds comments documenting everything discussed here and earlier on IRC.
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt, v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-416) modify cassandra.in.sh to only
set $CASSANDRA_CONF if it is not already set
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750998#action_12750998 ]
Hudson commented on CASSANDRA-416:
----------------------------------
Integrated in Cassandra #186 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/186/])
bin/cassandra improvements
- allow user-local configuration (~/.cassandra.in.sh)
- add comments documenting startup configuration
Patch by eevans; reviewed by jbellis and Lance Weber for
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-416
> Project: Cassandra
> Issue Type: Improvement
> Environment: unix/linux
> Reporter: Lance Weber
> Assignee: Eric Evans
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: cass_conf-patch.txt, v1-0001-CASSANDRA-416-bin-cassandra-improvements.txt
>
>
> modify cassandra.in.sh to only set $CASSANDRA_CONF if it is not already set
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.