You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Harrie Hazewinkel <ha...@covalent.net> on 2001/06/29 23:23:38 UTC

bug or a feature

HI all,


I noticed in the perfork MPM that the  'int worker_threads;'
of the 'struct process_score' has the value of '0'.
Is this correct, since there are no threads (as such)
or should it be '1' since there is just one (main) thread
per process.


Harrie
-- 
address: Covalent Technologies, 645 Howard St, San Francisco, CA - 94105
phone: +1-415-536-5221                               fax:+1-415-536-5210
personal website: http://www.lisanza.net/

Re: bug or a feature

Posted by Harrie Hazewinkel <ha...@covalent.net>.
"Paul J. Reder" wrote:
> 
> Harrie,
> 
> I added that field in preparation for the work I am still doing. 

OK.

> That
> field will put to use if the code I am working on gets accepted.

That is rebuilding the scorboard as a linked list isn't it??
I have been wondering about that. Are you each time going to 
lock the scoreboard when you change things?? Or are you going
to lock the scoreboard when you are going to provide
a status of the server with for instance SNMP or mod-status??



Harrie
-- 
address: Covalent Technologies, 645 Howard St, San Francisco, CA - 94105
phone: +1-415-536-5221                               fax:+1-415-536-5210
personal website: http://www.lisanza.net/

Re: bug or a feature

Posted by "Paul J. Reder" <re...@raleigh.ibm.com>.
They were put in the code after discussion and design had occurred here.
I laid out the stages that I was going to commit in, and I followed the
commit then review process.

There was no dissention when this was committed. Your disagreement and
veto came after the design had been discussed and this code had been committed.

rbb@covalent.net wrote:
> I have a problem with putting code like this in the tree.  If the code you
> are working on isn't accepted, are you going to remember to pull the
> fields?  They aren't marked in the current code as not used anywhere.

-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein

Re: bug or a feature

Posted by rb...@covalent.net.
On Fri, 29 Jun 2001, Paul J. Reder wrote:

> Harrie,
>
> I added that field in preparation for the work I am still doing. That
> field will put to use if the code I am working on gets accepted.

I have a problem with putting code like this in the tree.  If the code you
are working on isn't accepted, are you going to remember to pull the
fields?  They aren't marked in the current code as not used anywhere.

Ryan

_____________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
-----------------------------------------------------------------------------


Re: bug or a feature

Posted by "Paul J. Reder" <re...@raleigh.ibm.com>.
Harrie,

I added that field in preparation for the work I am still doing. That
field will put to use if the code I am working on gets accepted.

-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein