You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/10/10 17:25:22 UTC

Review Request 26557: Ambari throws Runtime exception for unrecognized components in DB.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26557/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7729
    https://issues.apache.org/jira/browse/AMBARI-7729


Repository: ambari


Description
-------

Related Jira: EAR - 408.

I see this exception in the server log,

    
    
    
    java.lang.RuntimeException: Trying to create a ServiceComponent not recognized in stack info, clusterName=HDSND004, serviceName=GANGLIA, componentName=MONITOR_WEBSERVER, stackInfo=HDP-1.3.3
    

If user modifies stack definition and upgrades, services disappear from the
UI, due to above exception.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 2661282 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d7880c4 

Diff: https://reviews.apache.org/r/26557/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 26557: Ambari throws Runtime exception for unrecognized components in DB.

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On Oct. 10, 2014, 10:13 p.m., Sid Wagle wrote:
> > Changes look good, what about saving stack info on rpm upgrade so that the changes do not vanish?

Already done in other ticket.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26557/#review56238
-----------------------------------------------------------


On Oct. 10, 2014, 3:25 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26557/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 3:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sid Wagle.
> 
> 
> Bugs: AMBARI-7729
>     https://issues.apache.org/jira/browse/AMBARI-7729
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Related Jira: EAR - 408.
> 
> I see this exception in the server log,
> 
>     
>     
>     
>     java.lang.RuntimeException: Trying to create a ServiceComponent not recognized in stack info, clusterName=HDSND004, serviceName=GANGLIA, componentName=MONITOR_WEBSERVER, stackInfo=HDP-1.3.3
>     
> 
> If user modifies stack definition and upgrades, services disappear from the
> UI, due to above exception.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 2661282 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d7880c4 
> 
> Diff: https://reviews.apache.org/r/26557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 26557: Ambari throws Runtime exception for unrecognized components in DB.

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26557/#review56238
-----------------------------------------------------------


Changes look good, what about saving stack info on rpm upgrade so that the changes do not vanish?

- Sid Wagle


On Oct. 10, 2014, 3:25 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26557/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 3:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sid Wagle.
> 
> 
> Bugs: AMBARI-7729
>     https://issues.apache.org/jira/browse/AMBARI-7729
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Related Jira: EAR - 408.
> 
> I see this exception in the server log,
> 
>     
>     
>     
>     java.lang.RuntimeException: Trying to create a ServiceComponent not recognized in stack info, clusterName=HDSND004, serviceName=GANGLIA, componentName=MONITOR_WEBSERVER, stackInfo=HDP-1.3.3
>     
> 
> If user modifies stack definition and upgrades, services disappear from the
> UI, due to above exception.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 2661282 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d7880c4 
> 
> Diff: https://reviews.apache.org/r/26557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 26557: Ambari throws Runtime exception for unrecognized components in DB.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26557/#review56148
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Oct. 10, 2014, 3:25 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26557/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 3:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sid Wagle.
> 
> 
> Bugs: AMBARI-7729
>     https://issues.apache.org/jira/browse/AMBARI-7729
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Related Jira: EAR - 408.
> 
> I see this exception in the server log,
> 
>     
>     
>     
>     java.lang.RuntimeException: Trying to create a ServiceComponent not recognized in stack info, clusterName=HDSND004, serviceName=GANGLIA, componentName=MONITOR_WEBSERVER, stackInfo=HDP-1.3.3
>     
> 
> If user modifies stack definition and upgrades, services disappear from the
> UI, due to above exception.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 2661282 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d7880c4 
> 
> Diff: https://reviews.apache.org/r/26557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 26557: Ambari throws Runtime exception for unrecognized components in DB.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26557/
-----------------------------------------------------------

(Updated Oct. 10, 2014, 3:25 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Sid Wagle.


Bugs: AMBARI-7729
    https://issues.apache.org/jira/browse/AMBARI-7729


Repository: ambari


Description
-------

Related Jira: EAR - 408.

I see this exception in the server log,

    
    
    
    java.lang.RuntimeException: Trying to create a ServiceComponent not recognized in stack info, clusterName=HDSND004, serviceName=GANGLIA, componentName=MONITOR_WEBSERVER, stackInfo=HDP-1.3.3
    

If user modifies stack definition and upgrades, services disappear from the
UI, due to above exception.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 2661282 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d7880c4 

Diff: https://reviews.apache.org/r/26557/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk