You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jdye64 <gi...@git.apache.org> on 2017/04/04 18:46:45 UTC

[GitHub] nifi pull request #1649: Support for websocket multiplexing to all existing ...

GitHub user jdye64 opened a pull request:

    https://github.com/apache/nifi/pull/1649

    Support for websocket multiplexing to all existing websocket

    connections (Think chat to all clients instead of individual person).
    The core change was a change in WebSocketMessageRouter.java where if a
    sessionId is not present the message is sent to all connected clients.
    So the key is leaving the sessionId to empty or null to send to all
    clients. If the sessionId is specified the message will be sent just to
    that session specified.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdye64/nifi NIFI-3318

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1649
    
----
commit d444d0addd454b619e917465aeab9b1cf8cc7ac4
Author: Jeremy Dyer <je...@apache.org>
Date:   2017-04-04T18:46:17Z

    Support for websocket multiplexing to all existing websocket
    connections (Think chat to all clients instead of individual person).
    The core change was a change in WebSocketMessageRouter.java where if a
    sessionId is not present the message is sent to all connected clients.
    So the key is leaving the sessionId to empty or null to send to all
    clients. If the sessionId is specified the message will be sent just to
    that session specified.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1649: NIFI-3318: Support for websocket multiplexing to al...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1649


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1649: NIFI-3318: Support for websocket multiplexing to all exist...

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1649
  
    @jdye64 Test with multiple WebSocket clients to receive messages sent from a NiFi at the same time. Works great, thanks for adding this! I'm +1 with the functional change, however, I'd like this feature to be documented so that users will be able to configure PutWebSocket as they want.
    
    Would you update Processor websocket-session-id property docs something like this? "A NiFi Expression to retrieve the session id. If not specified, a message will be sent to all connected WebSocket peer for the WebSocket controller service endpoint."
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1649: NIFI-3318: Support for websocket multiplexing to all exist...

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1649
  
    @jdye64 Thanks for updating the doc, all LGTM! Merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1649: NIFI-3318: Support for websocket multiplexing to all exist...

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1649
  
    Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---