[GitHub] [pinot] klsince commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

["klsince (via GitHub)" <gi...@apache.org>]

klsince commented on code in PR #10752:
URL: https://github.com/apache/pinot/pull/10752#discussion_r1196870494


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1555,4 +1562,19 @@ public PauseStatus getPauseStatus(String tableNameWithType) {
     Set<String> consumingSegments = findConsumingSegments(idealState);
     return new PauseStatus(Boolean.parseBoolean(isTablePausedStr), consumingSegments, null);
   }
+
+  @VisibleForTesting
+  String moveSegmentFile(String rawTableName, String segmentName, String segmentLocation, PinotFS pinotFS)
+      throws IOException {
+    URI segmentFileURI = URIUtils.getUri(segmentLocation);
+    URI uriToMoveTo = createSegmentPath(rawTableName, segmentName);

Review Comment:
   is there need to compare the two URIs and bail out if they are same? or we assume pinotFS.move() does the right thing. On a quick check of `BasePinotFS.move()`, it deletes `dstUri` before moving, so if the two URIs are same, then we lose the src too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org