You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/01/17 15:08:25 UTC
[GitHub] flink pull request #3139: [FLINK-5528][query][tests] reduce the retry delay ...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/3139
[FLINK-5528][query][tests] reduce the retry delay in QueryableStateITCase
Using 100ms instead of the 1s previously used does not impose too much
additional query load and reduces the test suite's duration from 16-20s to
13-15s on my machine with the current set of unit tests. Further reductions
in the retry delay do not yield more improvements so far.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-5528
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3139
----
commit d9070946d6f56e2b48d69b61608b10b063b456b4
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-01-17T14:01:32Z
[FLINK-5528][query][tests] reduce the retry delay in QueryableStateITCase
Using 100ms instead of the 1s previously used does not impose too much
additional query load and reduces the test suite's duration from 16-20s to
13-15s on my machine with the current set of unit tests. Further reductions
in the retry delay do not yield more improvements so far.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3139: [FLINK-5528][query][tests] reduce the retry delay ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3139#discussion_r97091734
--- Diff: flink-tests/src/test/java/org/apache/flink/test/query/QueryableStateITCase.java ---
@@ -1073,6 +1056,20 @@ public Integer getKey(Tuple2<Integer, Long> value) throws Exception {
}
}
+ /**
+ * Runs {@link #getKvStateWithRetries(QueryableStateClient, JobID, String,
+ * int, byte[], FiniteDuration)} with a fixed retry delay of 100ms.
+ */
+ private static Future<byte[]> getKvStateWithRetries(
+ final QueryableStateClient client,
+ final JobID jobId,
+ final String queryName,
+ final int key,
+ final byte[] serializedKey) {
+ return getKvStateWithRetries(client, jobId, queryName, key, serializedKey,
+ new FiniteDuration(100, TimeUnit.MILLISECONDS));
--- End diff --
I will make this a static final field of the class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3139: [FLINK-5528][query][tests] reduce the retry delay in Quer...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3139
Good idea! Will merge this with one minor change (see inline comment).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3139: [FLINK-5528][query][tests] reduce the retry delay ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---