You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 08:48:00 UTC

[GitHub] [flink] docete opened a new pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

docete opened a new pull request #12218:
URL: https://github.com/apache/flink/pull/12218


   …nvironment.connect().createTemporaryTable()
   
   
   ## What is the purpose of the change
   
   Since FLINK-14490 , proctime()/rowtime() doesn't work for TableEnvironment.connect().createTemporaryTable(), The root cause is described on jira ticket.
   
   ## Brief change log
   
   - instantiate the TableSource in CatalogSchemaTable and check if it's a DefinedRowtimeAttributes/DefinedProctimeAttribute instance. If so, rewrite the TableSchema to patch the time indicator(as it is in ConnectorCatalogTable#calculateSourceSchema)
   - avoid erasing time indicator in CatalogSourceTable if the TableSource is a DefinedRowtimeAttributes/DefinedProctimeAttribute instance
   
   ## Verifying this change
   
   This change added tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12218:
URL: https://github.com/apache/flink/pull/12218#issuecomment-630087514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ced394a88ef14eb97b61391aa2fb8b571c6b5977",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ced394a88ef14eb97b61391aa2fb8b571c6b5977",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ced394a88ef14eb97b61391aa2fb8b571c6b5977 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12218:
URL: https://github.com/apache/flink/pull/12218#issuecomment-630041237

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ced394a88ef14eb97b61391aa2fb8b571c6b5977 (Mon May 18 08:52:16 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12218:
URL: https://github.com/apache/flink/pull/12218#issuecomment-630041237

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ced394a88ef14eb97b61391aa2fb8b571c6b5977 (Fri Oct 16 10:49:43 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12218:
URL: https://github.com/apache/flink/pull/12218#issuecomment-630087514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ced394a88ef14eb97b61391aa2fb8b571c6b5977",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/166677325",
       "triggerID" : "ced394a88ef14eb97b61391aa2fb8b571c6b5977",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ced394a88ef14eb97b61391aa2fb8b571c6b5977 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/166677325) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12218:
URL: https://github.com/apache/flink/pull/12218#issuecomment-630087514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ced394a88ef14eb97b61391aa2fb8b571c6b5977",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/166677325",
       "triggerID" : "ced394a88ef14eb97b61391aa2fb8b571c6b5977",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ced394a88ef14eb97b61391aa2fb8b571c6b5977 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/166677325) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

Posted by GitBox <gi...@apache.org>.

wuchong merged pull request #12218:
URL: https://github.com/apache/flink/pull/12218


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] docete commented on pull request #12218: [FLINK-16160][table] Fix proctime()/rowtime() doesn't work for TableE…

Posted by GitBox <gi...@apache.org>.

docete commented on pull request #12218:
URL: https://github.com/apache/flink/pull/12218#issuecomment-630039520


   @wuchong This PR fix FLINK-16160 on release-1.10, please have a look and merge, Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org