You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/24 04:43:37 UTC
[GitHub] [flink] carp84 opened a new pull request #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
carp84 opened a new pull request #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670
## What is the purpose of the change
Currently we never uses the `sharedResources` in `RocksDBResourceContainer`, and in `RocksDBStateBackend.createKeyedStateBackend` we set the shared write buffer manager to the `dbOptions` but never pass/use it in `RocksDBKeyedStateBackendBuilder`, which leads to the result that different RocksDB backends actually are using separate write buffer managers thus the total memory control is invalid.
## Brief change log
Always set write buffer manager to the one from `sharedResources` if it's non-null, in `RocksDBResourceContainer.getDbOptions`.
## Verifying this change
This change added a new `testSharedResources` test case to cover the problematic case.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142193211 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142210095 TriggerType:PUSH TriggerID:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130
Hash:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3884 TriggerType:PUSH TriggerID:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
* 88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142193211) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878)
* 54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142210095) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3884)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142193211 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
* 88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142193211) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878)
* 54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-571602098
Taking a look now...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on issue #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
carp84 commented on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568651196
@Myasuka @StephanEwen Please help review when time allows, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-571620553
Good fix, +1 to merge for both `master` and `release-1.10`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-571654274
Merging this...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142193211 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
* 88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142193211) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142193211 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
* 88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142193211) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142193211 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142210095 TriggerType:PUSH TriggerID:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130
Hash:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3884 TriggerType:PUSH TriggerID:54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
* 88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142193211) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878)
* 54b5b8dd9b7839f81e56ef36a8a67e85f0f4c130 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142210095) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3884)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568651457
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit deed8274c86783bb2068acbcd9c6ad8d40b63f83 (Tue Dec 24 04:46:14 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
* 88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] asfgit closed pull request #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka removed a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
Myasuka removed a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568677004
LGTM
It could be better to describe clearly that once `sharedResources` is not null, we would set write buffer manager extracted from `sharedResources`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10670:
[FLINK-15370][state backends] Make sure sharedResources takes effect in
RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568658193
<!--
Meta data
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142188770 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:deed8274c86783bb2068acbcd9c6ad8d40b63f83 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871 TriggerType:PUSH TriggerID:deed8274c86783bb2068acbcd9c6ad8d40b63f83
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142193211 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
Hash:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878 TriggerType:PUSH TriggerID:88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec
-->
## CI report:
* deed8274c86783bb2068acbcd9c6ad8d40b63f83 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142188770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3871)
* 88d1a9ecbca46c2d452e058b3b9efaed1de8f6ec Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142193211) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on issue #10670: [FLINK-15370][state
backends] Make sure sharedResources takes effect in RocksDBResourceContainer
Posted by GitBox <gi...@apache.org>.
Myasuka commented on issue #10670: [FLINK-15370][state backends] Make sure sharedResources takes effect in RocksDBResourceContainer
URL: https://github.com/apache/flink/pull/10670#issuecomment-568677004
LGTM
It could be better to describe clearly that once `sharedResources` is not null, we would set write buffer manager extracted from `sharedResources`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services