You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/23 20:12:34 UTC
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8517: [Do not merge!] [TIR] cast disparate floating point types for binary ops
AndrewZhaoLuo commented on pull request #8517:
URL: https://github.com/apache/tvm/pull/8517#issuecomment-885889386
> As long as we don't implicitly downcast I think this should be fine, can you test behavior of storing both an i32/u32 computation in i16/u16, and the other way around?
This will fail since this PR only upcasts one arg. in binary operations only. Do you want me to also upcast assignment for floating point types to be consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org