You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2011/09/13 22:27:50 UTC

svn commit: r1170332 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java

Author: hlship
Date: Tue Sep 13 20:27:50 2011
New Revision: 1170332

URL: http://svn.apache.org/viewvc?rev=1170332&view=rev
Log:
TAP5-1644: Do not ignore the tapestry.compatibility.unknown-component-id-check-enabled setting

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java?rev=1170332&r1=1170331&r2=1170332&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java Tue Sep 13 20:27:50 2011
@@ -332,13 +332,15 @@ public class OnEventWorker implements Co
 
     private void addComponentIdValidationLogicOnPageLoad(PlasticClass plasticClass, Flow<EventHandlerMethod> eventHandlerMethods)
     {
-        ComponentIdValidator[] validators = extractComponentIdValidators(eventHandlerMethods);
-
-
-        if (validators.length > 0)
+        if (componentIdCheck)
         {
-            plasticClass.introduceInterface(PageLifecycleListener.class);
-            plasticClass.introduceMethod(TransformConstants.CONTAINING_PAGE_DID_LOAD_DESCRIPTION).addAdvice(new ValidateComponentIds(validators));
+            ComponentIdValidator[] validators = extractComponentIdValidators(eventHandlerMethods);
+
+            if (validators.length > 0)
+            {
+                plasticClass.introduceInterface(PageLifecycleListener.class);
+                plasticClass.introduceMethod(TransformConstants.CONTAINING_PAGE_DID_LOAD_DESCRIPTION).addAdvice(new ValidateComponentIds(validators));
+            }
         }
     }