[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4662: Add wait for condition for toggle test

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4662: Add wait for condition for toggle test
URL: https://github.com/apache/incubator-pinot/pull/4662#discussion_r330330448
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -268,44 +268,42 @@ private void addInstanceGroupTagIfNeeded() {
    */
 
   /**
-   * Get all instance Ids.
-   *
+   * Get all instance Ids. If it's related to segment operation like assigning segments to instances, cache accessor would be used.
+   * Otherwise, direct data accessor would be used.
+   * @param segmentRelatedOperation whether it's related to segment operation
    * @return List of instance Ids
    */
   @Nonnull
-  public List<String> getAllInstances() {
-    return _cacheInstanceConfigsDataAccessor.getChildNames("/", AccessOption.PERSISTENT);
+  public List<String> getAllInstances(boolean segmentRelatedOperation) {
 
 Review comment:
   You don't need to change this method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org