You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2023/12/27 08:22:54 UTC
[PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
zhiqiang-hhhh opened a new pull request, #29140:
URL: https://github.com/apache/doris/pull/29140
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #29140:
URL: https://github.com/apache/doris/pull/29140#issuecomment-1870071692
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29140:
URL: https://github.com/apache/doris/pull/29140#issuecomment-1870087547
TeamCity be ut coverage result:
Function Coverage: 36.59% (8582/23454)
Line Coverage: 28.65% (69749/243438)
Region Coverage: 27.62% (36048/130511)
Branch Coverage: 24.34% (18415/75644)
Coverage Report: http://coverage.selectdb-in.cc/coverage/00665171d98ff0d484c83bbc11899dd945037434_00665171d98ff0d484c83bbc11899dd945037434/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #29140:
URL: https://github.com/apache/doris/pull/29140#issuecomment-1870064958
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29140:
URL: https://github.com/apache/doris/pull/29140#issuecomment-1870323703
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29140:
URL: https://github.com/apache/doris/pull/29140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29140:
URL: https://github.com/apache/doris/pull/29140#issuecomment-1870098230
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.09 seconds
stream load tsv: 572 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17184307300 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29140:
URL: https://github.com/apache/doris/pull/29140#issuecomment-1870323728
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #29140:
URL: https://github.com/apache/doris/pull/29140#discussion_r1436841915
##########
be/src/pipeline/pipeline.cpp:
##########
@@ -71,14 +71,14 @@ Status Pipeline::prepare(RuntimeState* state) {
return Status::OK();
}
-Status Pipeline::set_sink(OperatorBuilderPtr& sink_) {
- if (_sink) {
+Status Pipeline::set_sink_builder(OperatorBuilderPtr& sink_) {
Review Comment:
warning: method 'set_sink_builder' can be made static [readability-convert-member-functions-to-static]
be/src/pipeline/pipeline.h:98:
```diff
- Status set_sink_builder(OperatorBuilderPtr& sink_operator_builder);
+ static Status set_sink_builder(OperatorBuilderPtr& sink_operator_builder);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rename) Rename some variables in pipeline for better readability [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29140:
URL: https://github.com/apache/doris/pull/29140#issuecomment-1870099066
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 00665171d98ff0d484c83bbc11899dd945037434, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4974 4694 4701 4694
q2 368 146 159 146
q3 1474 1302 1187 1187
q4 1134 955 873 873
q5 3169 3176 3141 3141
q6 249 129 127 127
q7 1029 501 490 490
q8 2275 2260 2254 2254
q9 6734 6703 6667 6667
q10 3188 3268 3276 3268
q11 340 207 205 205
q12 353 203 204 203
q13 4198 3413 3413 3413
q14 244 213 222 213
q15 560 513 520 513
q16 443 380 390 380
q17 1050 772 614 614
q18 7044 6873 7007 6873
q19 1606 1620 1640 1620
q20 526 339 302 302
q21 3163 2729 2694 2694
q22 364 301 318 301
Total cold run time: 44485 ms
Total hot run time: 40178 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4602 4566 4554 4554
q2 272 165 169 165
q3 3380 3368 3357 3357
q4 2235 2220 2212 2212
q5 5726 5722 5703 5703
q6 242 118 121 118
q7 2377 1836 1868 1836
q8 3613 3619 3609 3609
q9 9004 8991 8954 8954
q10 3792 3891 3907 3891
q11 493 368 367 367
q12 767 605 616 605
q13 3875 3177 3211 3177
q14 281 260 256 256
q15 572 525 520 520
q16 493 446 461 446
q17 1965 1974 1957 1957
q18 8727 8041 8298 8041
q19 1764 1781 1757 1757
q20 2246 1938 1920 1920
q21 6131 5815 5750 5750
q22 536 470 455 455
Total cold run time: 63093 ms
Total hot run time: 59650 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org