You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2018/03/14 07:04:52 UTC
[GitHub] nifi pull request #2542: NIFI-4971: ReportLineageToAtlas complete path can m...
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2542
NIFI-4971: ReportLineageToAtlas complete path can miss one-time lineages
The detailed explanation of this issue is written in the [NIFI-4971](https://issues.apache.org/jira/browse/NIFI-4971) JIRA description and comment. Please refer those as well.
- Separated Hook message de-duplication logic from NiFiAtlasHook to
NotificationSender
- NiFiAtlasHook used to send individual CREATE_ENTITY messages for each entities,
this commit changed it to bundle all new entities into a single
CREATE_ENTITY to preserve entity creation order, so that new DataSet
entities can be referred from new nifi_flow_path entities
- Added more unit tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4971
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2542
----
commit 378e63fd78ed9bdf1fc8256e9d269ae6f17e4ade
Author: Koji Kawamura <ij...@...>
Date: 2018-03-09T00:27:20Z
NIFI-4971: ReportLineageToAtlas complete path can miss one-time lineages
- Separated Hook message de-duplication logic from NiFiAtlasHook to
NotificationSender
- NiFiAtlasHook used to send individual CREATE_ENTITY messages for each entities,
this commit changed it to bundle all new entities into a single
CREATE_ENTITY to preserve entity creation order, so that new DataSet
entities can be referred from new nifi_flow_path entities
- Added more unit tests
----
---
[GitHub] nifi pull request #2542: NIFI-4971: ReportLineageToAtlas complete path can m...
Posted by ijokarumawak <gi...@git.apache.org>.
GitHub user ijokarumawak reopened a pull request:
https://github.com/apache/nifi/pull/2542
NIFI-4971: ReportLineageToAtlas complete path can miss one-time lineages
The detailed explanation of this issue is written in the [NIFI-4971](https://issues.apache.org/jira/browse/NIFI-4971) JIRA description and comment. Please refer those as well.
- Separated Hook message de-duplication logic from NiFiAtlasHook to
NotificationSender
- NiFiAtlasHook used to send individual CREATE_ENTITY messages for each entities,
this commit changed it to bundle all new entities into a single
CREATE_ENTITY to preserve entity creation order, so that new DataSet
entities can be referred from new nifi_flow_path entities
- Added more unit tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4971
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2542
----
commit 378e63fd78ed9bdf1fc8256e9d269ae6f17e4ade
Author: Koji Kawamura <ij...@...>
Date: 2018-03-09T00:27:20Z
NIFI-4971: ReportLineageToAtlas complete path can miss one-time lineages
- Separated Hook message de-duplication logic from NiFiAtlasHook to
NotificationSender
- NiFiAtlasHook used to send individual CREATE_ENTITY messages for each entities,
this commit changed it to bundle all new entities into a single
CREATE_ENTITY to preserve entity creation order, so that new DataSet
entities can be referred from new nifi_flow_path entities
- Added more unit tests
----
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2542
This PR has been superseded by #2577.
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2542
@ijokarumawak Needs a rebase. I might have time tomorrow to fire up Atlas and help you on this.
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2542
I'm not entirely sure. My experience with Atlas is very limited, and I'm mostly trying to figure out what to expect vs what I'd like to see if that makes any sense.
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2542
Thanks @MikeThomsen for confirming that. I hope that confirms this PR addresses the issue it supposed to fix. Are we good to merge this now?
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2542
I set everything up and set it to do `complete path.` This is what I got in Atlas:
<img width="1292" alt="screen shot 2018-04-24 at 10 17 16 am" src="https://user-images.githubusercontent.com/108184/39193186-f45d018c-47a8-11e8-9774-5c958d81bcb3.png">
<img width="1296" alt="screen shot 2018-04-24 at 10 18 03 am" src="https://user-images.githubusercontent.com/108184/39193187-f46e1b0c-47a8-11e8-9601-2ae647d58353.png">
---
[GitHub] nifi pull request #2542: NIFI-4971: ReportLineageToAtlas complete path can m...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak closed the pull request at:
https://github.com/apache/nifi/pull/2542
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2542
Should also mention that this is how I set it up per the Jira ticket:
<img width="792" alt="screen shot 2018-04-24 at 10 20 27 am" src="https://user-images.githubusercontent.com/108184/39193271-26aaf70c-47a9-11e8-8a5b-ddf10652005f.png">
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2542
@ijokarumawak I went back and looked at the Jira ticket again, and my interpretation is that what I saw in the screenshots above (with the graph) matches your description of the behavior you wanted to implement.
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2542
@MikeThomsen I might have missed your points, but let me answer to your comments.
For the lineage graphs showing two outgoing links from /tmp/in/test to two `GetFile, PutFile` processes going to the final /temp/out/test, I assume having two processes is what you are concerning. Can you share what the `qualified name` attributes of those two `nifi_flow_path` entities? I guess those have different qualified name and probably each created by 'simple path' and 'complete path' if you run the same flow with both strategies.
For the comment of not seeing any lineage with 'simple_path', Atlas does not draw lineage if you choose an entity which is subclass of 'Process'. When you selected the 'nifi_flow_path' entity, didn't its input/output attribute have link to the `fs_path` entities? If you follow the link, then lineage will be shown from the `fs_path` entity, which is a subclass of 'DataSet'.
Please let me know if above descriptions address your issues. Thanks!
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2542
@MikeThomsen Just wanted to check. Is there any other feedback, or did my last reply address your concerns? This fix is important not only for fixing issue with complete path, but also to reduce the amount of notification messages sent from NiFi to Atlas (thru Kafka) to lower Atlas workload. Thanks!
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2542
I have to rebuild and setup Atlas.
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2542
On a related note, @ijokarumawak, when it was on the simple path I had no lineage show up at all. See what I mean? (Bottom screenshot is a hybrid of both runs)
<img width="1292" alt="screen shot 2018-04-24 at 10 21 54 am" src="https://user-images.githubusercontent.com/108184/39193378-69634edc-47a9-11e8-9764-7d3c66ac7847.png">
<img width="1512" alt="screen shot 2018-04-24 at 10 23 12 am" src="https://user-images.githubusercontent.com/108184/39193438-8d5da1ca-47a9-11e8-9aac-ad6c32987877.png">
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2542
Closed different PR by mistake. Reopening ..
---
[GitHub] nifi issue #2542: NIFI-4971: ReportLineageToAtlas complete path can miss one...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2542
Thank you @MikeThomsen for jumping on this. Rebased with the latest master.
---
[GitHub] nifi pull request #2542: NIFI-4971: ReportLineageToAtlas complete path can m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2542
---