[GitHub] [flink] godfreyhe commented on a change in pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate
URL: https://github.com/apache/flink/pull/8389#discussion_r283616783
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalTableSourceScan.scala
 ##########
 @@ -81,7 +81,13 @@ class FlinkLogicalTableSourceScan(
     val terms = super.explainTerms(pw)
         .item("fields", tableSource.getTableSchema.getFieldNames.mkString(", "))
 
-    val sourceDesc = tableSource.explainSource()
+    val auxiliarySourceDesc = tableSource match {
+      case fts: FilterableTableSource[_] =>
+        s"FilterPushDown=${fts.isFilterPushedDown.toString}"
 
 Review comment:
   `s"FilterPushDown=${fts.isFilterPushedDown.toString}"` is not the digest of a `FilterableTableSource `,  consider the following case: there are several different filters to be pushed down. 
   so, i think the digest should be the string value of the pushed filters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services