[GitHub] [trafficserver-ingress-controller] rishabhc commented on a change in pull request #32: Helm support

[GitBox <gi...@apache.org>]

rishabhc commented on a change in pull request #32:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/32#discussion_r463440161



##########
File path: charts/TODO.md
##########
@@ -0,0 +1,35 @@
+# TODO for Helm support
+Helm support for ATS Ingress Controller is still under development and can only be used locally after building the following docker images:
+- ats_alpine
+- tsexporter
+
+After building the above images, do the following to install ATS Ingress using Helm:
+1. `$ kubectl create namespace ats-ingress`
+    - Create the namespace where the ingress controller will be installed
+2. `$ helm install charts/ats-ingress --generate-name -n ats-ingress`

Review comment:
       I tested if the installation works without a secret but ATS shuts down if the TLS certificate fields are empty so now I've changed the TODO to indicate it can only run when TLS certificate is present. 
   I think we should also add support in the case users don't want TLS 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org