You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/08/30 23:01:17 UTC
[PR] Remove dead xml-apis dependency exclusions [grails-core]
codeconsole opened a new pull request, #16279:
URL: https://github.com/apache/grails-core/pull/16279
`xml-apis:xml-apis` has not been reachable from any of these dependencies for several major versions, so the four exclusions are no-ops:
- **`hibernate-core` 7.4.1.Final** and **`hibernate-core-jakarta` 5.6.15.Final** never declare `xml-apis`. Hibernate's own POM already excludes it from every one of its dependencies, and mapping XML has been bound with JAXB (`jakarta.xml.bind-api` + `jaxb-runtime`) since Hibernate 6 dropped dom4j.
- **`commons-validator` 1.9.0** no longer pulls `commons-digester`/`xml-apis`.
### Verification
With the exclusions removed, `dependencyInsight --dependency xml-apis` finds no match on `compileClasspath`, `runtimeClasspath`, or `testRuntimeClasspath` for any of the three modules, and the full resolved dependency graphs are byte-identical to before.
The only publication change is the removal of three dead `<exclusion>` entries from the generated POMs (the fourth is on a `compileOnly` dependency, which is not published).
`:grails-datamapping-validation:test`, `:grails-data-hibernate7-core:test` and `:grails-data-hibernate5-core:test` pass (3066 tests, 0 failures), and `aggregateStyleViolations` reports no Checkstyle or CodeNarc violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dead xml-apis dependency exclusions [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #16279:
URL: https://github.com/apache/grails-core/pull/16279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dead xml-apis dependency exclusions [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16279:
URL: https://github.com/apache/grails-core/pull/16279#issuecomment-5472021149
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16279?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.7139%. Comparing base ([`4309d5b`](https://app.codecov.io/gh/apache/grails-core/commit/4309d5b876614920b39721e425559f61779d9c12?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e469c27`](https://app.codecov.io/gh/apache/grails-core/commit/e469c27e11a237b99691835b1b3f13ea1099ede1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 8.0.x #16279 +/- ##
==================================================
- Coverage 54.7149% 54.7139% -0.0010%
Complexity 20421 20421
==================================================
Files 2101 2101
Lines 100978 100978
Branches 17907 17907
==================================================
- Hits 55250 55249 -1
Misses 37860 37860
- Partials 7868 7869 +1
```
[see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16279/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dead xml-apis dependency exclusions [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16279:
URL: https://github.com/apache/grails-core/pull/16279#issuecomment-5471901207
## 🚨 TestLens detected 1 failed test 🚨
Here is what you can do:
1) Inspect the test failures carefully.
2) If you are convinced that some of the tests are flaky, you can mute them below.
3) Finally, trigger a rerun by checking the rerun checkbox.
### Test Summary
#### [CI / Functional Tests \(Java 25, indy\=false, shard 1\)](https://github.com/apache/grails-core/actions/runs/33340675541/job/99335640828?pr=16279) > :grails-test-examples-gsp-sitemesh3:integrationTest
| Test | Runs | Flakiness |
|---|---|--:|
| EndToEndSpec > async multiple levels of layouts | ❌ | [1% 🟡](https://github.com/apache/grails-core/issues/16030) |
🏷️ Commit: e469c27e11a237b99691835b1b3f13ea1099ede1
▶️ Tests: 28713 executed
🟡 Checks: 28/77 completed
### Test Failures
<details>
<summary><strong>EndToEndSpec > async multiple levels of layouts</strong> (:grails-test-examples-gsp-sitemesh3:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33340675541/job/99335640828?pr=16279">CI / Functional Tests (Java 25, indy=false, shard 1)</a>)</summary>
```
Condition not satisfied:
pageSource == """<html><head><title>Decorated Base - Dialog - This is the title</title><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head> <body><h1>Hello</h1><div id="base"><div id="dialog">body text</div></div> </body></html>"""
| |
| false
| Strings too large to calculate edit distance.
<html lang="en"><head><title>HTTP Status 500 – Internal Server Error</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 500 – Internal Server Error</h1></body></html>
at EndToEndSpec.async multiple levels of layouts(EndToEndSpec.groovy:107)
```
|expected|actual|
|---|---|
|\<html\>\<head\>\<title\><s>Decorated</s> <s>Base</s> <s>-</s> <s>Dialog</s> <s>-</s> <s>This</s> <s>is the title</s>\</title\>\<<s>meta</s> <s>http</s>-<s>equiv\=\"Content</s>-<s>Type\"</s> <s>content\=\"text/html</s>; <s>charset\=UTF</s>-<s>8\"</s>\>\</head\>|\<html<b> lang\=\"en\"</b>\>\<head\>\<title\><b>HTTP</b> <b>Status</b> <b>500</b> <b>–</b> <b>Internal</b> <b>Server</b> <b>Error</b>\</title\>\<<b>style</b> <b>type\=\"text/css\"\>body \{font</b>-<b>family:Tahoma,Arial,sans</b>-<b>serif;\}</b> <b>h1, h2, h3, b \{color:white</b>;<b>background-color:<span>#</span>525D76;\}</b> <b>h1 \{font</b>-<b>size:22px;\} h2 \{font-size:16px;\} h3 \{font-size:14px;\} p \{font-size:12px;\} a \{color:black;\} .line \{height:1px;background-color:<span>#</span>525D76;border:none;\}\</style</b>\>\</head<b>\>\<body\>\<h1</b>\><b>HTTP Status 500 – Internal Server Error\</h1\>\</body\>\</html\></b>|
|<s>\<body\>\<h1\>Hello\</h1\>\<div id\=\"base\"\>\<div id\=\"dialog\"\>body text\</div\>\</div\></s>||
|<s>\</body\>\</html\></s>||
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 EndToEndSpec > async multiple levels of layouts <!-- uniqueId=[engine:spock]/[spec:EndToEndSpec]/[feature:$spock_feature_1_7] -->
Reuse successful test results:
🔲 ♻️ Only rerun the tests that failed or were muted before
Click the checkbox to trigger a rerun:
🔲 **Rerun jobs**
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org