[jira] [Commented] (BOOKKEEPER-422) Simplify AbstractSubscriptionManager

["Flavio Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472537#comment-13472537 ] 

Flavio Junqueira commented on BOOKKEEPER-422:
---------------------------------------------

It mostly looks good to me. The only comment I have is that this patch removes this:

{code}
-    Callback<Void> noopCallback = new NoopCallback<Void>();
-
-    static class NoopCallback<T> implements Callback<T> {
{code}

and similar patterns are used in ConsumerHandler and ChannelTracker. Should we consider making similar changes there too and perhaps in a separate jira just so that we don't mix the issues?
                
> Simplify AbstractSubscriptionManager
> ------------------------------------
>
>                 Key: BOOKKEEPER-422
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-422
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: hedwig-server
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>            Priority: Minor
>         Attachments: bk-422.diff
>
>
> It's difficult to maintain a duplicated/cached count of local subscribers, and we've experienced a few issues due to it getting out of sync with the actual set of subscribers. Since a count of local subscribers can be calculated from the top2sub2seq map, let's do that instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira