You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/10/28 15:26:23 UTC
[jira] Created: (LUCENE-2726) simulate disk fulls in copyBytes
simulate disk fulls in copyBytes
--------------------------------
Key: LUCENE-2726
URL: https://issues.apache.org/jira/browse/LUCENE-2726
Project: Lucene - Java
Issue Type: Test
Components: Build
Reporter: Robert Muir
Fix For: 3.1, 4.0
In LUCENE-2637, i disabled copyBytes optimization (so it just calls writeBytes), but i mentioned there,
that I think it would be good to try to beef up tests if we ever wanted to have an optimization like this.
the problem was that when there was an index corruption bug, it was very difficult to detect with our tests.
So I think for safety, we should do this, even though its redundant with our current impl, since we look
for this in writeBytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2726) simulate disk fulls in copyBytes
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2726:
--------------------------------
Fix Version/s: (was: 3.1)
> simulate disk fulls in copyBytes
> --------------------------------
>
> Key: LUCENE-2726
> URL: https://issues.apache.org/jira/browse/LUCENE-2726
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-2726.patch
>
>
> In LUCENE-2637, i disabled copyBytes optimization (so it just calls writeBytes), but i mentioned there,
> that I think it would be good to try to beef up tests if we ever wanted to have an optimization like this.
> the problem was that when there was an index corruption bug, it was very difficult to detect with our tests.
> So I think for safety, we should do this, even though its redundant with our current impl, since we look
> for this in writeBytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2726) simulate disk fulls in copyBytes
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2726:
--------------------------------
Attachment: LUCENE-2726.patch
here's a patch, uses the same logic to check as writeBytes does.
> simulate disk fulls in copyBytes
> --------------------------------
>
> Key: LUCENE-2726
> URL: https://issues.apache.org/jira/browse/LUCENE-2726
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2726.patch
>
>
> In LUCENE-2637, i disabled copyBytes optimization (so it just calls writeBytes), but i mentioned there,
> that I think it would be good to try to beef up tests if we ever wanted to have an optimization like this.
> the problem was that when there was an index corruption bug, it was very difficult to detect with our tests.
> So I think for safety, we should do this, even though its redundant with our current impl, since we look
> for this in writeBytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2726) simulate disk fulls in copyBytes
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925806#action_12925806 ]
Robert Muir commented on LUCENE-2726:
-------------------------------------
So the question here, is how to account for the fact that copyBytes might call writeBytes (like it does today), and not double-count the bytes for disk full.
> simulate disk fulls in copyBytes
> --------------------------------
>
> Key: LUCENE-2726
> URL: https://issues.apache.org/jira/browse/LUCENE-2726
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2726.patch
>
>
> In LUCENE-2637, i disabled copyBytes optimization (so it just calls writeBytes), but i mentioned there,
> that I think it would be good to try to beef up tests if we ever wanted to have an optimization like this.
> the problem was that when there was an index corruption bug, it was very difficult to detect with our tests.
> So I think for safety, we should do this, even though its redundant with our current impl, since we look
> for this in writeBytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org