You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/04/30 00:51:08 UTC
Review Request 70570: Logged headroom related info in the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Logged headroom related info in the allocator.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
Diff: https://reviews.apache.org/r/70570/diff/1/
Testing
-------
N/A
Thanks,
Meng Zhu
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215081
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70570]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 30, 2019, 1 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated April 30, 2019, 1 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch logs `requiredHeadroom` and `availableHeadroom`
> before each allocation cycle and logs `requiredHeadroom`,
> resources and number of agents held back for quota `headroom`
> as well as resources filtered at the end of each allocation
> cycle.
>
> While we also held resources back for quota headroom in the
> first stage, we do not log it there. This is because in the
> second stage, we try to allocate all resources (including the
> ones held back in the first stage). Thus only resources held
> back in the second stage are truly held back for the whole
> allocation cycle.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/4/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215168
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.cpp
Lines 2012-2015 (patched)
<https://reviews.apache.org/r/70570/#comment301703>
I don't think we need to quote out the variables like this, as it tends to lead to a more verbose comment than necessary, e.g.:
```
For logging purposes, we track the number of agents that had
resources held back for quota headroom, as well as how many
resources in total were held back.
```
src/master/allocator/mesos/hierarchical.cpp
Lines 2119 (patched)
<https://reviews.apache.org/r/70570/#comment301704>
more importantly, we do not track it there? right? (the logging seems secondary to the fact that we don't track the information in the first stage)
probably this comment about how we track it should be up above the variables rather than in the logging of it?
src/master/allocator/mesos/hierarchical.cpp
Lines 2128 (patched)
<https://reviews.apache.org/r/70570/#comment301705>
is this accurate?
it can actually be a combination of: filtering, limits being reached, and suppressed roles?
Maybe don't include this for now and just log the available headroom?
- Benjamin Mahler
On May 9, 2019, 12:22 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated May 9, 2019, 12:22 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch logs `requiredHeadroom` and `availableHeadroom`
> before each allocation cycle and logs `requiredHeadroom`,
> resources and number of agents held back for quota `headroom`
> as well as resources filtered at the end of each allocation
> cycle.
>
> While we also held resources back for quota headroom in the
> first stage, we do not log it there. This is because in the
> second stage, we try to allocate all resources (including the
> ones held back in the first stage). Thus only resources held
> back in the second stage are truly held back for the whole
> allocation cycle.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/5/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215180
-----------------------------------------------------------
Bad review!
Reviews applied: [70570]
Error:
2019-05-10 09:12:39 URL:https://reviews.apache.org/r/70570/diff/raw/ [2537/2537] -> "70570.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1795
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
- Mesos Reviewbot
On May 9, 2019, 12:22 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated May 9, 2019, 12:22 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch logs `requiredHeadroom` and `availableHeadroom`
> before each allocation cycle and logs `requiredHeadroom`,
> resources and number of agents held back for quota `headroom`
> as well as resources filtered at the end of each allocation
> cycle.
>
> While we also held resources back for quota headroom in the
> first stage, we do not log it there. This is because in the
> second stage, we try to allocate all resources (including the
> ones held back in the first stage). Thus only resources held
> back in the second stage are truly held back for the whole
> allocation cycle.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 708c444ea93a63d566a81b31c4c79ed65949e1a4
>
>
> Diff: https://reviews.apache.org/r/70570/diff/6/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215154
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70570]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 9, 2019, 12:22 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated May 9, 2019, 12:22 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch logs `requiredHeadroom` and `availableHeadroom`
> before each allocation cycle and logs `requiredHeadroom`,
> resources and number of agents held back for quota `headroom`
> as well as resources filtered at the end of each allocation
> cycle.
>
> While we also held resources back for quota headroom in the
> first stage, we do not log it there. This is because in the
> second stage, we try to allocate all resources (including the
> ones held back in the first stage). Thus only resources held
> back in the second stage are truly held back for the whole
> allocation cycle.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/5/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/
-----------------------------------------------------------
(Updated May 8, 2019, 5:22 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Addressed Ben's comment.
Bugs: MESOS-9759
https://issues.apache.org/jira/browse/MESOS-9759
Repository: mesos
Description
-------
This patch logs `requiredHeadroom` and `availableHeadroom`
before each allocation cycle and logs `requiredHeadroom`,
resources and number of agents held back for quota `headroom`
as well as resources filtered at the end of each allocation
cycle.
While we also held resources back for quota headroom in the
first stage, we do not log it there. This is because in the
second stage, we try to allocate all resources (including the
ones held back in the first stage). Thus only resources held
back in the second stage are truly held back for the whole
allocation cycle.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
Diff: https://reviews.apache.org/r/70570/diff/5/
Changes: https://reviews.apache.org/r/70570/diff/4-5/
Testing
-------
N/A
Thanks,
Meng Zhu
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review214957
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70570']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3292/mesos-review-70570
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3292/mesos-review-70570/logs/mesos-tests.log):
```
I0430 04:06:53.211923 83292 master.cpp:3312] Disconnecting agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0 at slave(504)@192.10.1.4:55439 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 04:06:53.211923 83292 master.cpp:3331] Deactivating agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0 at slave(504)@192.10.1.4:55439 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 04:06:53.212929 85624 hierarchical.cpp:392] Removed framework 788f8f53-65da-4a4b-b1be-1380ca138371-0000
I0430 04:06:53.212929 85624 hierarchical.cpp:829] Agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0 deactivated
I0430 04:06:53.212929 76512 containerizer.cpp:2586] Destroying container 0dd6f354-d988-4087-85f9-88ab3d16b61c in RUNNING state
I0430 04:06:53.212929 76512 containerizer.cpp:3288] Transitioning the state of container 0dd6f354-d988-4087-85f9-88ab3d16b61c from RUNNING to DESTROYING
I0430 04:06:5[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (787 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (806 ms total)
[----------] Global test environment tear-down
[==========] 1166 tests from 109 test cases ran. (598202 ms total)
[ PASSED ] 1163 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
3 FAILED TESTS
YOU HAVE 233 DISABLED TESTS
3.213939 76512 launcher.cpp:161] Asked to destroy container 0dd6f354-d988-4087-85f9-88ab3d16b61c
W0430 04:06:53.214936 88912 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=11160 to peer '192.10.1.4:57847': IO failed with error code: The specified network name is no longer available.
W0430 04:06:53.214936 88912 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=11068 to peer '192.10.1.4:57848': IO failed with error code: The specified network name is no longer available.
I0430 04:06:53.303535 79568 containerizer.cpp:3127] Container 0dd6f354-d988-4087-85f9-88ab3d16b61c has exited
I0430 04:06:53.333674 76512 master.cpp:1135] Master terminating
I0430 04:06:53.335544 59164 hierarchical.cpp:680] Removed agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0
I0430 04:06:54.658576 88912 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 30, 2019, 1 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated April 30, 2019, 1 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Logged headroom related info in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On May 6, 2019, 1:50 p.m., Benjamin Mahler wrote:
> > Hm.. don't we need to track the amount held back during the quota allocation? What are your thoughts on that?
We hold back something in the quota allocation loop, then in the second stage, we try to allocate everything (including the “held back” in the 1st stage).
> On May 6, 2019, 1:50 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 1930-1942 (original), 1934-1946 (patched)
> > <https://reviews.apache.org/r/70570/diff/3/?file=2142150#file2142150line1934>
> >
> > Isn't this also holding back for headroom?
We hold back something in the quota allocation loop, then in the second stage, we try to allocate everything (including the “held back” in the 1st stage).
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215071
-----------------------------------------------------------
On May 8, 2019, 5:22 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated May 8, 2019, 5:22 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch logs `requiredHeadroom` and `availableHeadroom`
> before each allocation cycle and logs `requiredHeadroom`,
> resources and number of agents held back for quota `headroom`
> as well as resources filtered at the end of each allocation
> cycle.
>
> While we also held resources back for quota headroom in the
> first stage, we do not log it there. This is because in the
> second stage, we try to allocate all resources (including the
> ones held back in the first stage). Thus only resources held
> back in the second stage are truly held back for the whole
> allocation cycle.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/5/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215071
-----------------------------------------------------------
Hm.. don't we need to track the amount held back during the quota allocation? What are your thoughts on that?
src/master/allocator/mesos/hierarchical.cpp
Lines 1800 (patched)
<https://reviews.apache.org/r/70570/#comment301463>
"and available"
or
" ; available"
src/master/allocator/mesos/hierarchical.cpp
Lines 1930-1942 (original), 1934-1946 (patched)
<https://reviews.apache.org/r/70570/#comment301464>
Isn't this also holding back for headroom?
src/master/allocator/mesos/hierarchical.cpp
Lines 2012-2019 (patched)
<https://reviews.apache.org/r/70570/#comment301466>
Probably clearer with a single comment above the two variables about what we track for logging purposes?
src/master/allocator/mesos/hierarchical.cpp
Lines 2018 (patched)
<https://reviews.apache.org/r/70570/#comment301465>
s/these/this/ ?
src/master/allocator/mesos/hierarchical.cpp
Lines 2019 (patched)
<https://reviews.apache.org/r/70570/#comment301468>
size_t?
src/master/allocator/mesos/hierarchical.cpp
Lines 2090 (patched)
<https://reviews.apache.org/r/70570/#comment301467>
pre-increment?
src/master/allocator/mesos/hierarchical.cpp
Lines 2122 (patched)
<https://reviews.apache.org/r/70570/#comment301469>
were held back
src/master/allocator/mesos/hierarchical.cpp
Lines 2123 (patched)
<https://reviews.apache.org/r/70570/#comment301470>
"for that" -> "to ensure sufficient headroom"
src/master/allocator/mesos/hierarchical.cpp
Lines 2124 (patched)
<https://reviews.apache.org/r/70570/#comment301471>
"were filtered"
- Benjamin Mahler
On April 30, 2019, 1 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated April 30, 2019, 1 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Logged headroom related info in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/3/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review214956
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70570]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 30, 2019, 9 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated April 30, 2019, 9 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Logged headroom related info in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215038
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70570]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 30, 2019, 1 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated April 30, 2019, 1 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Logged headroom related info in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/3/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review214982
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp
Lines 1798-1799 (patched)
<https://reviews.apache.org/r/70570/#comment301265>
Can we also say what needs to be held back?
Hm.. I wonder if we should this information log before and after the allocation cycle completes?
- Benjamin Mahler
On April 30, 2019, 1 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
>
> (Updated April 30, 2019, 1 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9759
> https://issues.apache.org/jira/browse/MESOS-9759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Logged headroom related info in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
>
>
> Diff: https://reviews.apache.org/r/70570/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70570: Logged headroom related info in the
allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/
-----------------------------------------------------------
(Updated April 29, 2019, 6 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Fixed a slip.
Repository: mesos
Description
-------
Logged headroom related info in the allocator.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87
Diff: https://reviews.apache.org/r/70570/diff/2/
Changes: https://reviews.apache.org/r/70570/diff/1-2/
Testing
-------
N/A
Thanks,
Meng Zhu