[GitHub] incubator-rya pull request #263: RYA-413 Fixed how MongoDBRyaDAO closed its ...

[ejwhite922 <gi...@git.apache.org>]

GitHub user ejwhite922 opened a pull request:

    https://github.com/apache/incubator-rya/pull/263

    RYA-413 Fixed how MongoDBRyaDAO closed its internal mongoClient. Updated AbstractMongoDBRdfConfigurationBuilder config tags.

    ## Description
    If the MongoDBRyaDAO is destroyed, its internal mongoClient is not disposed correctly. This leaves the mongoClient closed which causes problems the next time the MongoDBRyaDAO is created.
    
    The mongoClient is managed by MongoConnectorFactory and needs to be null'ed out to be recreated properly (by calling MongoConnectorFactory.closeMongoClient(); instead of mongoClient.close();)
    
    Some new unit tests were added to test reconstructing the DAO. They failed with the old way of using mongoClient.close() and pass with the new way of using MongoConnectorFactory.closeMongoClient().
    
    Also, all the static final config tags inside AbstractMongoDBRdfConfigurationBuilder were changed from protected to public (like AbstractAccumuloRdfConfigurationBuilder has) so they could be used inside other tests that make use of the tags.
    
    NOTE: This is the same as [PR 253](https://github.com/apache/incubator-rya/pull/253) just recreated off of master after some rebasing issues with other PR.
    
    ### Tests
    Unit tests
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-413)
    
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    
    #### People To Review
    @meiercaleb
    @kchilton2
    @jessehatfield
    @isper3at
    @DLotts
    @pujav65


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ejwhite922/incubator-rya RYA-413_MongoDBRyaDAOClosing_RebasedOnMaster

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit 0e5024f1e4f2d12509e87b292c1fc899ef3c9ad4
Author: eric.white <er...@...>
Date:   2018-01-05T16:38:48Z

    RYA-413 Fixed how MongoDBRyaDAO closed its internal mongoClient. Updated AbstractMongoDBRdfConfigurationBuilder config tags.

----


---

[GitHub] incubator-rya pull request #263: RYA-413 Fixed how MongoDBRyaDAO closed its ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rya/pull/263


---

[GitHub] incubator-rya issue #263: RYA-413 Fixed how MongoDBRyaDAO closed its interna...

[asfgit <gi...@git.apache.org>]

Github user asfgit commented on the issue:

    https://github.com/apache/incubator-rya/pull/263
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/663/



---