[GitHub] [flink-connector-kafka] PatrickRen commented on a diff in pull request #41: [FLINK-32591][Connectors/Kafka] Update document of Kafka Source: Enab…

["PatrickRen (via GitHub)" <gi...@apache.org>]

PatrickRen commented on code in PR #41:
URL: https://github.com/apache/flink-connector-kafka/pull/41#discussion_r1264964369


##########
docs/content/docs/connectors/table/kafka.md:
##########
@@ -364,9 +364,9 @@ Connector Options
       <td><h5>scan.topic-partition-discovery.interval</h5></td>
       <td>optional</td>
       <td>yes</td>
-      <td style="word-wrap: break-word;">(none)</td>
+      <td style="word-wrap: break-word;">5 minutes</td>
       <td>Duration</td>
-      <td>Interval for consumer to discover dynamically created Kafka topics and partitions periodically.</td>
+      <td>Interval for consumer to discover dynamically created Kafka topics and partitions periodically.To disable this feature, you need to explicitly set the 'scan.topic-partition-discovery.interval' value to 0.</td>

Review Comment:
   A space is required after the period
   ```suggestion
         <td>Interval for consumer to discover dynamically created Kafka topics and partitions periodically. To disable this feature, you need to explicitly set the 'scan.topic-partition-discovery.interval' value to 0.</td>
   ```



##########
docs/content/docs/connectors/datastream/kafka.md:
##########
@@ -264,8 +264,7 @@ KafkaSource.builder() \
 {{< /tabs >}}
 
 {{< hint warning >}}
-Partition discovery is **disabled** by default. You need to explicitly set the partition discovery
-interval to enable this feature.
+The partition discovery interval is 5 minutes by default.To **disable** this feature, you need to explicitly set the partition discovery interval to a non-positive value.

Review Comment:
   Same problem as above
   ```suggestion
   The partition discovery interval is 5 minutes by default. To **disable** this feature, you need to explicitly set the partition discovery interval to a non-positive value.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org