You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/23 03:46:43 UTC

Re: Review Request 12780: Fixed the Jenkins framework to reject master URLs with "http://".

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12780/
-----------------------------------------------------------

(Updated July 23, 2013, 1:46 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Updated to reject "http://" URLs.


Summary (updated)
-----------------

Fixed the Jenkins framework to reject master URLs with "http://".


Repository: mesos-git


Description
-------

See above.


Diffs (updated)
-----

  jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java 340f75f478010c4276ddd67caa2fbb9295a5ca58 

Diff: https://reviews.apache.org/r/12780/diff/


Testing
-------

None as of yet ;)


Thanks,

Ben Mahler

Re: Review Request 12780: Fixed the Jenkins framework to reject master URLs with "http://".

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12780/#review23678
-----------------------------------------------------------

Ship it!


i committed my jenkins related changes. you should be able to test it now :) 

make jenkins && mvn hpi:run

- Vinod Kone


On July 23, 2013, 1:46 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12780/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 1:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See above.
> 
> 
> Diffs
> -----
> 
>   jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java 340f75f478010c4276ddd67caa2fbb9295a5ca58 
> 
> Diff: https://reviews.apache.org/r/12780/diff/
> 
> 
> Testing
> -------
> 
> None as of yet ;)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>