You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/03 09:43:04 UTC
[GitHub] [druid] davidferlay opened a new pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
davidferlay opened a new pull request #11846:
URL: https://github.com/apache/druid/pull/11846
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
### Fixes #11814.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
- `yaml.load_all` is missing `Loader` parameter in these 2 files :
- https://github.com/apache/druid/blob/druid-0.22.0/distribution/bin/generate-binary-license.py
- https://github.com/apache/druid/blob/druid-0.22.0/distribution/bin/generate-binary-notice.py
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] davidferlay commented on pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
davidferlay commented on pull request #11846:
URL: https://github.com/apache/druid/pull/11846#issuecomment-952028001
Followup of https://github.com/apache/druid/pull/11815#issuecomment-951247121 :
- https://github.com/yaml/pyyaml/blob/master/CHANGES#L17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 closed pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 closed pull request #11846:
URL: https://github.com/apache/druid/pull/11846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 closed pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 closed pull request #11846:
URL: https://github.com/apache/druid/pull/11846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis closed pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
clintropolis closed pull request #11846:
URL: https://github.com/apache/druid/pull/11846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] davidferlay commented on pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
davidferlay commented on pull request #11846:
URL: https://github.com/apache/druid/pull/11846#issuecomment-952689525
Updating CI pyyaml to latest version (6.0) since it's the one introducing that breaking change
1 test fails though, maybe it should be updated to fit pyyaml 6.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] davidferlay commented on pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
davidferlay commented on pull request #11846:
URL: https://github.com/apache/druid/pull/11846#issuecomment-952722957
Added `--ignore-installed` flag to `pip3 install pyyaml==6.0` in `.travis` file fixed the CI
It means something else is bringing an old pyyaml. Maybe someone want to have a look at that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] 2bethere commented on pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
2bethere commented on pull request #11846:
URL: https://github.com/apache/druid/pull/11846#issuecomment-956401485
Let me back out my changes on the license issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] 2bethere commented on pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
2bethere commented on pull request #11846:
URL: https://github.com/apache/druid/pull/11846#issuecomment-956401485
Let me back out my changes on the license issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on pull request #11846:
URL: https://github.com/apache/druid/pull/11846#issuecomment-955239941
Thanks you for your contribution. Seems like this PR #11857 also is trying to fix the license problem and is changing the same files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 closed pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 closed pull request #11846:
URL: https://github.com/apache/druid/pull/11846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 closed pull request #11846: Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 closed pull request #11846:
URL: https://github.com/apache/druid/pull/11846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org