You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/09/16 09:19:22 UTC
[GitHub] [spark] panbingkun commented on a diff in pull request #42952: [SPARK-45184][SQL] Remove orphaned error class documents
panbingkun commented on code in PR #42952:
URL: https://github.com/apache/spark/pull/42952#discussion_r1327937136
##########
core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:
##########
@@ -222,6 +223,21 @@ class SparkThrowableSuite extends SparkFunSuite {
|---""".stripMargin
}
+ def orphanedGoldenFiles(): Iterable[File] = {
+ val errors = errorReader.errorInfoMap
+ val subErrorFileNames = errors.filter(_._2.subClass.isDefined).map(error => {
+ getErrorPath(error._1) + ".md"
+ }).toSet
+
+ val docsDir = getWorkspaceFilePath("docs")
+ val orphans = FileUtils.listFiles(docsDir.toFile, Array("md"), false).filter { f =>
+ (f.getName.startsWith("sql-error-conditions-") && f.getName.endsWith("-error-class.md")) &&
+ !f.getName.equals("sql-error-conditions-sqlstates.md") &&
Review Comment:
Yeah, let me remove it.
All done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org