[GitHub] [hive] pudidic commented on a diff in pull request #3999: HIVE-26921: Add failover_type and failover_endpoint as new member to metadata column in replication_metrics table

["pudidic (via GitHub)" <gi...@apache.org>]

pudidic commented on code in PR #3999:
URL: https://github.com/apache/hive/pull/3999#discussion_r1094030970


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/repl/ReplConst.java:
##########
@@ -82,4 +84,10 @@ public class ReplConst {
   public static final String BOOTSTRAP_DUMP_STATE_KEY_PREFIX = "bootstrap.dump.state.";
 
   public static final String READ_ONLY_HOOK = "org.apache.hadoop.hive.ql.hooks.EnforceReadOnlyDatabaseHook";
+
+  /**
+   * Type of failover
+   */
+  public static final String PLANNED_FAILOVER = "PLANNED";

Review Comment:
   It's usually better to create an enum for types.
   https://docs.oracle.com/javase/tutorial/java/javaOO/enum.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org