You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/05/22 08:31:22 UTC

[GitHub] zeppelin pull request #2976: [ZEPPELIN-3478] Download Data as CSV downloads ...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2976

    [ZEPPELIN-3478] Download Data as CSV downloads data as a single line

    ### What is this PR for?
    All data is in one single line - lines separated with backslash and "n" sequence and not actual newline characters "\n".
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    
    ### What is the Jira issue?
    * [ZEPPELIN-3478](https://issues.apache.org/jira/browse/ZEPPELIN-3478)
    
    ### How should this be tested?
    All the exports should work in all browsers
     * Export this notebook
     * Export as CVS
     * Export as TSV
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3478

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2976.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2976
    
----
commit 62ea2e57e7f6f9e6d9bc6bc9c2ec6f0cde4e2fd9
Author: Prabhjyot Singh <pr...@...>
Date:   2018-05-22T07:58:00Z

    ZEPPELIN-3478: Download Data as CSV downloads data as a single line
    
    Change-Id: I377b8e4b5d47ad0dd402cad997c1952a302bb243

----


---

[GitHub] zeppelin issue #2976: [ZEPPELIN-3478] Download Data as CSV downloads data as...

Posted by Tagar <gi...@git.apache.org>.

Github user Tagar commented on the issue:

    https://github.com/apache/zeppelin/pull/2976
  
    LGTM 
    Verified manually - this patch fixes the issue.
    Thanks a lot @prabhjyotsingh 


---

[GitHub] zeppelin issue #2976: [ZEPPELIN-3478] Download Data as CSV downloads data as...

Posted by Tagar <gi...@git.apache.org>.

Github user Tagar commented on the issue:

    https://github.com/apache/zeppelin/pull/2976
  
    thanks for prompt response @prabhjyotsingh 
    I will give this a try today.


---

[GitHub] zeppelin pull request #2976: [ZEPPELIN-3478] Download Data as CSV downloads ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2976


---

[GitHub] zeppelin issue #2976: [ZEPPELIN-3478] Download Data as CSV downloads data as...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2976
  
    Thanks for the review will merge this to master and branch-0.8 if no more discussion.


---

[GitHub] zeppelin issue #2976: [ZEPPELIN-3478] Download Data as CSV downloads data as...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2976
  
    @Tagar @r-kamath  can you help review this.


---

[GitHub] zeppelin issue #2976: [ZEPPELIN-3478] Download Data as CSV downloads data as...

Posted by r-kamath <gi...@git.apache.org>.

Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2976
  
    LGTM


---