[GitHub] [iceberg] Fokko commented on issue #6120: [Python] The structure of a partition definition and partition instance should be consistent

[GitBox <gi...@apache.org>]

Fokko commented on issue #6120:
URL: https://github.com/apache/iceberg/issues/6120#issuecomment-1303064851

   Hey @ddrinka Thanks for opening the PR. The date is a so-called logical type that most storage formats store internally as the days since 1970-01-01. After reading, this should be converted into a date again. For the PartitionSummary, we convert it into the physical type (int) and compare it with the partition.
   
   It seems that the `DateLiteral` is missing here: https://github.com/apache/iceberg/blob/master/python/pyiceberg/expressions/literals.py#L108-L164 It would be great if you can open up a PR to fix this 👍🏻 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org