You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "cvictory (GitHub)" <gi...@apache.org> on 2019/01/03 11:02:28 UTC
[GitHub] [incubator-dubbo] cvictory opened pull request #3129: fix #3124 . move RegistryDataConfig configuration into RegistryConfig…
1. remove registryDataConfig , and move some configuration into RegistryConfig
2. remove logic : consumer url extra key。（消费者往注册中心写的URL不需要额外的key）
3. camel format support
----
fix #3124
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3129 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on pull request #3129: fix #3124 . move RegistryDataConfig configuration into RegistryConfig…
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
in the future, we should categorize such constants into groups, for this case, it'd be better and more clear if we move it into RegistryConstants. @cvictory, would you mind to file one issue against this suggestion?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3129 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3129: fix #3124 . move RegistryDataConfig configuration into RegistryConfig…
Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
@cvictory would it be possible to bit explain it bit here, what we are doing here?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3129 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #3129: fix #3124 . move RegistryDataConfig configuration into RegistryConfig…
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3129 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3129: fix #3124 . move RegistryDataConfig configuration into RegistryConfig…
Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
ok. 👍
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3129 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on pull request #3129: fix #3124 . move RegistryDataConfig configuration into RegistryConfig…
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
@khanimteyaz in `2.7.0` we hope to simplify URL put into the registry center.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3129 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3129: fix #3124 . move RegistryDataConfig configuration into RegistryConfig…
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3129?src=pr&el=h1) Report
> Merging [#3129](https://codecov.io/gh/apache/incubator-dubbo/pull/3129?src=pr&el=desc) into [2.7.0-release](https://codecov.io/gh/apache/incubator-dubbo/commit/3bf77abd86e7d51c74df307c4608b0294d89ca57?src=pr&el=desc) will **increase** coverage by `1.14%`.
> The diff coverage is `20%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3129?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.7.0-release #3129 +/- ##
===================================================
+ Coverage 62.53% 63.68% +1.14%
Complexity 75 75
===================================================
Files 674 651 -23
Lines 30172 28150 -2022
Branches 5070 4774 -296
===================================================
- Hits 18868 17926 -942
+ Misses 8940 7981 -959
+ Partials 2364 2243 -121
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3129?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvU2VydmljZUJlYW4uamF2YQ==) | `48.95% <ø> (+1.97%)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `58.49% <ø> (+0.21%)` | `0 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `92.85% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `53.64% <ø> (-0.1%)` | `0 <0> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdEludGVyZmFjZUNvbmZpZy5qYXZh) | `73.44% <ø> (+0.18%)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `38% <ø> (+2.15%)` | `0 <0> (ø)` | :arrow_down: |
| [...g/context/annotation/DubboConfigConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvbi5qYXZh) | `66.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `82.81% <0%> (+0.64%)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `81.18% <33.33%> (-3.03%)` | `0 <0> (ø)` | |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `56.25% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3129/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3129?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3129?src=pr&el=footer). Last update [3bf77ab...2e91dad](https://codecov.io/gh/apache/incubator-dubbo/pull/3129?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3129 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org