You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/23 20:32:16 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6153: NIFI-10163 Correct StandardProcessSession.exportTo() byte counting

exceptionfactory opened a new pull request, #6153:
URL: https://github.com/apache/nifi/pull/6153

   # Summary
   
   [NIFI-10163](https://issues.apache.org/jira/browse/NIFI-10163) Corrects counting of bytes read and bytes written in `StandardProcessSession.exportTo(FlowFile, OutputStream)` to reflect the the number of bytes processed through the `ByteCountingInputStream`, which wraps the source content stream. This approach follows a strategy similar to the `StandardProcessSession.exportTo(FlowFile, Path)` method, which increments bytes read and bytes written based on the number of bytes copied.
   
   This change corrects tracking of `Bytes Read` and `Bytes Transferred` in the `Status History` for Processors such as `InvokeHTTP` and `HandleHttpResponse`.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog closed pull request #6153: NIFI-10163 Correct StandardProcessSession.exportTo() byte counting

Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6153: NIFI-10163 Correct StandardProcessSession.exportTo() byte counting
URL: https://github.com/apache/nifi/pull/6153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6153: NIFI-10163 Correct StandardProcessSession.exportTo() byte counting

Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6153:
URL: https://github.com/apache/nifi/pull/6153#issuecomment-1171536795

   Thanks @exceptionfactory looks good to me. I'm a +1. Will hold off on merging for now though since @thenatog is reviewing. @thenatog please do merge if you're happy with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6153: NIFI-10163 Correct StandardProcessSession.exportTo() byte counting

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6153:
URL: https://github.com/apache/nifi/pull/6153#issuecomment-1171743366

   Thanks, +1 will merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6153: NIFI-10163 Correct StandardProcessSession.exportTo() byte counting

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6153:
URL: https://github.com/apache/nifi/pull/6153#issuecomment-1171500084

   Will review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org