You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/25 20:57:59 UTC

[GitHub] [geode] echobravopapa opened a new pull request #5561: try a diff exception

echobravopapa opened a new pull request #5561:
URL: https://github.com/apache/geode/pull/5561


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal closed pull request #5561: try a diff exception

Posted by GitBox <gi...@apache.org>.
onichols-pivotal closed pull request #5561:
URL: https://github.com/apache/geode/pull/5561


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal closed pull request #5561: try a diff exception

Posted by GitBox <gi...@apache.org>.
onichols-pivotal closed pull request #5561:
URL: https://github.com/apache/geode/pull/5561


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #5561: try a diff exception

Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #5561:
URL: https://github.com/apache/geode/pull/5561#issuecomment-725538465


   Looks like the test failures are due to the new Exception being thrown, with intentional-error messaging. So, failing as designs? The 2nd code change looks like the removal of some logging, and should probably be put back before merge. Also, this is still a draft. Are you wanting to continue work on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal commented on pull request #5561: try a diff exception

Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5561:
URL: https://github.com/apache/geode/pull/5561#issuecomment-807965800


   This PR has been open for some while with no recent activity.  Please keep Geode tidy by closing PRs you're not actively using.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] lgtm-com[bot] commented on pull request #5561: try a diff exception

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5561:
URL: https://github.com/apache/geode/pull/5561#issuecomment-699168122


   This pull request **introduces 1 alert** and **fixes 1** when merging c51ed007bcd7d6435f2829e14f65520fdd39cf05 into c05118a5cf31cdd20e595ea9093809eb9f6872fc - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-1e9f8cc094752f9b5dd7470495f1cf47fb72d617)
   
   **new alerts:**
   
   * 1 for Implicit conversion from array to string
   
   **fixed alerts:**
   
   * 1 for Implicit conversion from array to string


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org