You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Dmitry Lychagin (Code Review)" <do...@asterixdb.incubator.apache.org> on 2018/10/01 18:08:36 UTC
Change in asterixdb[master]: [NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf()
Dmitry Lychagin has posted comments on this change.
Change subject: [NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf()
......................................................................
Patch Set 1:
(5 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnan/ifnan.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnan/ifnan.1.adm:
Line 3: [ 2, false ]
Can you change queries instead, so the expected result remains "true"? So if the query was doing ismissing() and now we return null then change it to isnull()
https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnanorinf/ifnanorinf.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnanorinf/ifnanorinf.1.adm:
Line 3: [ 2, false ]
same comment. change query instead so the expected result remains "true"
https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfInfDescriptor.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfInfDescriptor.java:
PS1, Line 33: definiion
typo, should be: definition
https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanDescriptor.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanDescriptor.java:
PS1, Line 33: definiion
definition
https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanOrInfDescriptor.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanOrInfDescriptor.java:
PS1, Line 42: definiion
definition
--
To view, visit https://asterix-gerrit.ics.uci.edu/2981
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7cc3d18ca0443857ae271b6e14f2c9e920f1c1f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes