You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/21 11:55:34 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #581: chore: deployment update and remove all files related to MySQL
nic-chen opened a new pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581
1. update build and run scripts (local, docker and compose)
2. update docs about build and run
3. remove all files related to MySQL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509785209
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
-```sh
-# e.g Initialization for MySQL, please use a more secure Password instead of 123456.
-$ mysql –uroot –p123456
-> source ./api/script/db/schema.sql
-```
-
-2. Start the Apache APISIX.
+2. Check environment variables
-[Please follow this guide](https://github.com/apache/apisix#configure-and-installation)
-
-3. Check environment variables
+- enable Go MODULE
+```
+go env -w GO111MODULE=on
+```
-According to your local deployment environment, check the environment variables in `./api/run/run.sh`, modify the environment variables if needed.
+- According to your local deployment environment, check the environment variables in `./api/run.sh`, modify the environment variables if needed.
-For most users in China, we could use [Goproxy](https://goproxy.cn/) to speed up downloading modules.
+- For most users in China, we could use [Goproxy](https://goproxy.cn/) to speed up downloading modules.
Review comment:
ok
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
-```sh
-# e.g Initialization for MySQL, please use a more secure Password instead of 123456.
-$ mysql –uroot –p123456
-> source ./api/script/db/schema.sql
-```
-
-2. Start the Apache APISIX.
+2. Check environment variables
-[Please follow this guide](https://github.com/apache/apisix#configure-and-installation)
-
-3. Check environment variables
+- enable Go MODULE
+```
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509966151
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
@membphis
we could take a try later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509344025
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
> But I think we can build it in development phase, no need build it at installing
agree +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509250324
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
Why we need lua?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509257959
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
-```sh
-# e.g Initialization for MySQL, please use a more secure Password instead of 123456.
-$ mysql –uroot –p123456
-> source ./api/script/db/schema.sql
-```
-
-2. Start the Apache APISIX.
+2. Check environment variables
-[Please follow this guide](https://github.com/apache/apisix#configure-and-installation)
-
-3. Check environment variables
+- enable Go MODULE
+```
+go env -w GO111MODULE=on
+```
-According to your local deployment environment, check the environment variables in `./api/run/run.sh`, modify the environment variables if needed.
+- According to your local deployment environment, check the environment variables in `./api/run.sh`, modify the environment variables if needed.
-For most users in China, we could use [Goproxy](https://goproxy.cn/) to speed up downloading modules.
+- For most users in China, we could use [Goproxy](https://goproxy.cn/) to speed up downloading modules.
Review comment:
We can add a concrete command, such as
```
export GOPROXY=https://goproxy.cn,direct
```
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
Maybe for build jsonschema?
But I think we can build it in development phase, no need build it at installing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509280167
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
-```sh
-# e.g Initialization for MySQL, please use a more secure Password instead of 123456.
-$ mysql –uroot –p123456
-> source ./api/script/db/schema.sql
-```
-
-2. Start the Apache APISIX.
+2. Check environment variables
-[Please follow this guide](https://github.com/apache/apisix#configure-and-installation)
-
-3. Check environment variables
+- enable Go MODULE
+```
Review comment:
Would better add language here to support code highlight
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
-```sh
-# e.g Initialization for MySQL, please use a more secure Password instead of 123456.
-$ mysql –uroot –p123456
-> source ./api/script/db/schema.sql
-```
-
-2. Start the Apache APISIX.
+2. Check environment variables
-[Please follow this guide](https://github.com/apache/apisix#configure-and-installation)
-
-3. Check environment variables
+- enable Go MODULE
+```
+go env -w GO111MODULE=on
Review comment:
`$ xxx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509956896
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
> Is this the same etcd used by Apache APISIX?
Yes
> Here are the compilation steps. It can be compiled without etcd, right?
You are right, we can compile it without etcd
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
> Is this the same etcd used by Apache APISIX?
Yes
> Here are the compilation steps. It can be compiled without etcd, right?
You are right, we can compile it without etcd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509949105
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
And why we need to install etcd first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#issuecomment-714294708
any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509951112
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
manager api depend on ETCD, so we need a etcd instance before run manager api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509955529
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
Is this the same etcd used by Apache APISIX?
Here are the compilation steps. It can be compiled without etcd, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509859684
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
@nic-chen
take a look at this project: https://github.com/yuin/gopher-lua .
I think it should be a better way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509781739
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
@moonming @ShiningRush @membphis
we need Lua to generate jsonschema and to generate lua code for plugin orchestration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #581: chore: deployment update and remove all files related to MySQL
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #581:
URL: https://github.com/apache/apisix-dashboard/pull/581#discussion_r509973966
##########
File path: README.md
##########
@@ -49,35 +49,25 @@ $ cd apisix-dashboard
The `manager-api` is used to provide APIs for Dashboard, just like a bridge between the Apache APISIX and the Dashboard. Here are the steps to build it manually:
-1. We need `MySQL/Golang` to be preinstalled.
+1. We need `Go` 1.13+, `ETCD` 3.4+ and `Lua` 5.1+ to be preinstalled.
Review comment:
@moonming @ShiningRush I have updated the doc about ETCD. please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org