You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/24 02:16:16 UTC
[GitHub] [shardingsphere] Lucas-307 opened a new pull request #8308: move check package into job package
Lucas-307 opened a new pull request #8308:
URL: https://github.com/apache/shardingsphere/pull/8308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8308: Optimize scaling-core package
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8308:
URL: https://github.com/apache/shardingsphere/pull/8308#issuecomment-732577788
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=h1) Report
> Merging [#8308](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=desc) (3cf972e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0bfe11eb839d1bb2bda84ae1cf7495eb6c0c8bda?el=desc) (0bfe11e) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8308 +/- ##
============================================
- Coverage 74.04% 74.02% -0.02%
Complexity 599 599
============================================
Files 1494 1494
Lines 23642 23642
Branches 4179 4179
============================================
- Hits 17505 17501 -4
- Misses 4988 4990 +2
- Partials 1149 1151 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ingsphere/scaling/core/job/ShardingScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2hhcmRpbmdTY2FsaW5nSm9iLmphdmE=) | `86.95% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...core/job/check/AbstractDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvY2hlY2svQWJzdHJhY3REYXRhQ29uc2lzdGVuY3lDaGVja2VyLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...ing/core/job/check/DataConsistencyCheckResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvY2hlY2svRGF0YUNvbnNpc3RlbmN5Q2hlY2tSZXN1bHQuamF2YQ==) | `80.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [.../core/job/check/DataConsistencyCheckerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvY2hlY2svRGF0YUNvbnNpc3RlbmN5Q2hlY2tlckZhY3RvcnkuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [.../core/job/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2hhcmRpbmdTY2FsaW5nSm9iUHJlcGFyZXIuamF2YQ==) | `92.85% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...caling/core/service/AbstractScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL0Fic3RyYWN0U2NhbGluZ0pvYlNlcnZpY2UuamF2YQ==) | `88.23% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ore/service/impl/DistributedScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL2ltcGwvRGlzdHJpYnV0ZWRTY2FsaW5nSm9iU2VydmljZS5qYXZh) | `94.73% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...core/service/impl/StandaloneScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL2ltcGwvU3RhbmRhbG9uZVNjYWxpbmdKb2JTZXJ2aWNlLmphdmE=) | `85.29% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...hardingsphere/scaling/mysql/MySQLScalingEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMU2NhbGluZ0VudHJ5LmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...g/mysql/component/MySQLDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NvbXBvbmVudC9NeVNRTERhdGFDb25zaXN0ZW5jeUNoZWNrZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=footer). Last update [0bfe11e...1e6d8fe](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #8308: Optimize scaling-core package
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #8308:
URL: https://github.com/apache/shardingsphere/pull/8308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8308: Optimize scaling-core package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8308:
URL: https://github.com/apache/shardingsphere/pull/8308#issuecomment-732577788
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=h1) Report
> Merging [#8308](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=desc) (3cf972e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0bfe11eb839d1bb2bda84ae1cf7495eb6c0c8bda?el=desc) (0bfe11e) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8308 +/- ##
============================================
- Coverage 74.04% 74.02% -0.02%
Complexity 599 599
============================================
Files 1494 1494
Lines 23642 23642
Branches 4179 4179
============================================
- Hits 17505 17502 -3
- Misses 4988 4990 +2
- Partials 1149 1150 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ingsphere/scaling/core/job/ShardingScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2hhcmRpbmdTY2FsaW5nSm9iLmphdmE=) | `86.95% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...core/job/check/AbstractDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvY2hlY2svQWJzdHJhY3REYXRhQ29uc2lzdGVuY3lDaGVja2VyLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...ing/core/job/check/DataConsistencyCheckResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvY2hlY2svRGF0YUNvbnNpc3RlbmN5Q2hlY2tSZXN1bHQuamF2YQ==) | `80.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [.../core/job/check/DataConsistencyCheckerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvY2hlY2svRGF0YUNvbnNpc3RlbmN5Q2hlY2tlckZhY3RvcnkuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [.../core/job/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2hhcmRpbmdTY2FsaW5nSm9iUHJlcGFyZXIuamF2YQ==) | `92.85% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...caling/core/service/AbstractScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL0Fic3RyYWN0U2NhbGluZ0pvYlNlcnZpY2UuamF2YQ==) | `88.23% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ore/service/impl/DistributedScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL2ltcGwvRGlzdHJpYnV0ZWRTY2FsaW5nSm9iU2VydmljZS5qYXZh) | `94.73% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...core/service/impl/StandaloneScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL2ltcGwvU3RhbmRhbG9uZVNjYWxpbmdKb2JTZXJ2aWNlLmphdmE=) | `85.29% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...hardingsphere/scaling/mysql/MySQLScalingEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMU2NhbGluZ0VudHJ5LmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...g/mysql/component/MySQLDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NvbXBvbmVudC9NeVNRTERhdGFDb25zaXN0ZW5jeUNoZWNrZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/8308/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=footer). Last update [0bfe11e...1e6d8fe](https://codecov.io/gh/apache/shardingsphere/pull/8308?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org