You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/19 23:17:10 UTC

Re: Review Request 41461: Added SFINAE-friendly `result_of` in stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41461/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 10:17 p.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere.


Summary (updated)
-----------------

Added SFINAE-friendly `result_of` in stout.


Bugs: MESOS-4220
    https://issues.apache.org/jira/browse/MESOS-4220


Repository: mesos


Description
-------

VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so `result_of` must be replaced with `decltype(invoke)`.

Here, we implement SFINAE `result_of` in `stout`.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41461/diff/


Testing
-------

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41461: Added SFINAE-friendly `result_of` in stout.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41461/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 10:42 p.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere.


Changes
-------

Addressed BenH's comment.


Bugs: MESOS-4220
    https://issues.apache.org/jira/browse/MESOS-4220


Repository: mesos


Description
-------

VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so `result_of` must be replaced with `decltype(invoke)`.

Here, we implement SFINAE `result_of` in `stout`.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am b257ab2609a5b39a28d5f7003b22fac54d7380d4 
  3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41461/diff/


Testing
-------

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park