You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rj...@apache.org on 2009/01/03 01:58:12 UTC
svn commit: r730881 - in /httpd/httpd/trunk: configure.in support/Makefile.in
Author: rjung
Date: Fri Jan 2 16:58:11 2009
New Revision: 730881
URL: http://svn.apache.org/viewvc?rev=730881&view=rev
Log:
We need to link only ab against libm (because of
sqrt()).
Modified:
httpd/httpd/trunk/configure.in
httpd/httpd/trunk/support/Makefile.in
Modified: httpd/httpd/trunk/configure.in
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/configure.in?rev=730881&r1=730880&r2=730881&view=diff
==============================================================================
--- httpd/httpd/trunk/configure.in (original)
+++ httpd/httpd/trunk/configure.in Fri Jan 2 16:58:11 2009
@@ -390,7 +390,13 @@
AC_C_CONST
dnl ## Check for library functions
+dnl ## sqrt() only needed in support/ab.c
+saved_LIBS="$LIBS"
+LIBS=""
AC_SEARCH_LIBS(sqrt, m)
+MATH_LIBS="$LIBS"
+APACHE_SUBST(MATH_LIBS)
+LIBS="$saved_LIBS"
dnl See Comment #Spoon
Modified: httpd/httpd/trunk/support/Makefile.in
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/support/Makefile.in?rev=730881&r1=730880&r2=730881&view=diff
==============================================================================
--- httpd/httpd/trunk/support/Makefile.in (original)
+++ httpd/httpd/trunk/support/Makefile.in Fri Jan 2 16:58:11 2009
@@ -50,7 +50,7 @@
$(LINK) $(htdbm_LTFLAGS) $(htdbm_OBJECTS) $(PROGRAM_LDADD)
ab_OBJECTS = ab.lo
-ab_LDADD = $(PROGRAM_LDADD) $(SSL_LIBS)
+ab_LDADD = $(PROGRAM_LDADD) $(SSL_LIBS) $(MATH_LIBS)
ab: $(ab_OBJECTS)
$(LINK) $(ab_LTFLAGS) $(ab_OBJECTS) $(ab_LDADD)
Re: svn commit: r730881 - in /httpd/httpd/trunk: configure.in support/Makefile.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Rainer Jung wrote:
>
> That's the platform I do most tests on. I compiled all trunk modules and
> could load them, so no missing symbols.
>
> I do the same change regularly for 2.2.x, so I know it works there to
> (but didn't test there with all more exotic modules).
Cool, leaving the change on trunk, we can enhance it later after we
determine an appropriate AP_NEEDS_LIBM macro test for the particulars.
This is what alpha's are for :)
Re: svn commit: r730881 - in /httpd/httpd/trunk: configure.in support/Makefile.in
Posted by Rainer Jung <ra...@kippdata.de>.
On 03.01.2009 02:50, William A. Rowe, Jr. wrote:
> Rainer Jung wrote:
>> On 03.01.2009 02:02, William A. Rowe, Jr. wrote:
>>> rjung@apache.org wrote:
>>>> Author: rjung
>>>> Date: Fri Jan 2 16:58:11 2009
>>>> New Revision: 730881
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=730881&view=rev
>>>> Log:
>>>> We need to link only ab against libm (because of
>>>> sqrt()).
>>> Uhm - sure that mod_status and a few others didn't also need this
>>> on some platforms due to double/float arithmetic (statistics?)
>> It's always hard to be sure for all platforms, but at least it works on
>> Solaris and Linux, and I can't find any libm symbols in mod_status.
>>
>> The floats there are only used in simple divisions and printf.
>>
>> As I understand it, Windows builds are not influenced by these changes,
>> because they use a separate build apparatus?
>
> Correct, but if I remember right, manipulating long long's into doubles
> on solaris 8 and several other operating systems involves libm stub helpers.
That's the platform I do most tests on. I compiled all trunk modules and
could load them, so no missing symbols.
I do the same change regularly for 2.2.x, so I know it works there to
(but didn't test there with all more exotic modules).
Re: svn commit: r730881 - in /httpd/httpd/trunk: configure.in support/Makefile.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Rainer Jung wrote:
> On 03.01.2009 02:02, William A. Rowe, Jr. wrote:
>> rjung@apache.org wrote:
>>> Author: rjung
>>> Date: Fri Jan 2 16:58:11 2009
>>> New Revision: 730881
>>>
>>> URL: http://svn.apache.org/viewvc?rev=730881&view=rev
>>> Log:
>>> We need to link only ab against libm (because of
>>> sqrt()).
>>
>> Uhm - sure that mod_status and a few others didn't also need this
>> on some platforms due to double/float arithmetic (statistics?)
>
> It's always hard to be sure for all platforms, but at least it works on
> Solaris and Linux, and I can't find any libm symbols in mod_status.
>
> The floats there are only used in simple divisions and printf.
>
> As I understand it, Windows builds are not influenced by these changes,
> because they use a separate build apparatus?
Correct, but if I remember right, manipulating long long's into doubles
on solaris 8 and several other operating systems involves libm stub helpers.
Re: svn commit: r730881 - in /httpd/httpd/trunk: configure.in support/Makefile.in
Posted by Rainer Jung <ra...@kippdata.de>.
On 03.01.2009 02:02, William A. Rowe, Jr. wrote:
> rjung@apache.org wrote:
>> Author: rjung
>> Date: Fri Jan 2 16:58:11 2009
>> New Revision: 730881
>>
>> URL: http://svn.apache.org/viewvc?rev=730881&view=rev
>> Log:
>> We need to link only ab against libm (because of
>> sqrt()).
>
> Uhm - sure that mod_status and a few others didn't also need this
> on some platforms due to double/float arithmetic (statistics?)
It's always hard to be sure for all platforms, but at least it works on
Solaris and Linux, and I can't find any libm symbols in mod_status.
The floats there are only used in simple divisions and printf.
As I understand it, Windows builds are not influenced by these changes,
because they use a separate build apparatus?
Regards,
Rainer
Re: svn commit: r730881 - in /httpd/httpd/trunk: configure.in support/Makefile.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
rjung@apache.org wrote:
> Author: rjung
> Date: Fri Jan 2 16:58:11 2009
> New Revision: 730881
>
> URL: http://svn.apache.org/viewvc?rev=730881&view=rev
> Log:
> We need to link only ab against libm (because of
> sqrt()).
Uhm - sure that mod_status and a few others didn't also need this
on some platforms due to double/float arithmetic (statistics?)
Re: svn commit: r730881 - in /httpd/httpd/trunk: configure.in support/Makefile.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
rjung@apache.org wrote:
> Author: rjung
> Date: Fri Jan 2 16:58:11 2009
> New Revision: 730881
>
> URL: http://svn.apache.org/viewvc?rev=730881&view=rev
> Log:
> We need to link only ab against libm (because of
> sqrt()).
Uhm - sure that mod_status and a few others didn't also need this
on some platforms due to double/float arithmetic (statistics?)