[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5364: Core, API: Support scanning from refs

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r953291463


##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -60,6 +61,7 @@ final class TableScanContext {
     this.planExecutor = null;
     this.fromSnapshotInclusive = false;
     this.scanReporter = new LoggingScanReporter();
+    this.ref = null;

Review Comment:
   Technically with the current scan support we don't even need to store ref in the context. at the end of the day with the ref scanning we're scanning from a single snapshot, so we could just resolve the snapshot and set it as before. I'll think some more if this is really needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org