You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/29 04:12:39 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3422: [Bug] Fix bug that load to data to wrong temp partitions
morningman opened a new pull request #3422:
URL: https://github.com/apache/incubator-doris/pull/3422
When loading data without specifying partition, the data should only be loaded to
formal partitions, not including temp partitions;
Fix: #3421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3422: [Bug] Fix bug that load to data to wrong temp partitions
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3422:
URL: https://github.com/apache/incubator-doris/pull/3422#discussion_r417789053
##########
File path: fe/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java
##########
@@ -185,6 +185,10 @@ public TExecPlanFragmentParams plan(TUniqueId loadId) throws UserException {
}
partitionIds.add(part.getId());
}
+ } else {
+ for (Partition partition : destTable.getPartitions()) {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3422: [Bug] Fix bug that load to data to wrong temp partitions
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #3422:
URL: https://github.com/apache/incubator-doris/pull/3422#discussion_r417792563
##########
File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -88,7 +88,8 @@
private final TableName tblName;
private final PartitionNames targetPartitionNames;
- // parsed from targetPartitionNames. empty means no partition specified
+ // parsed from targetPartitionNames.
+ // if targetPartitionNames is not set, add all partitions' id of the table into it
Review comment:
add all partition's id except temp partition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3422: [Bug] Fix bug that load to data to wrong temp partitions
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3422:
URL: https://github.com/apache/incubator-doris/pull/3422#discussion_r417421694
##########
File path: fe/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java
##########
@@ -185,6 +185,10 @@ public TExecPlanFragmentParams plan(TUniqueId loadId) throws UserException {
}
partitionIds.add(part.getId());
}
+ } else {
+ for (Partition partition : destTable.getPartitions()) {
Review comment:
Add a comment to explain why we return all partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org