You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "zRains (via GitHub)" <gi...@apache.org> on 2024/08/10 20:46:45 UTC
[PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
zRains opened a new pull request, #3809:
URL: https://github.com/apache/ambari/pull/3809
## What changes were proposed in this pull request?
With the arrival of the `ambari-web` upgrade PR: #3770 , `PhantomJS` is no longer sufficient to support future testing tasks, as its support for ES5 has been abandoned([#14506](https://github.com/ariya/phantomjs/issues/14506), [#14458](https://github.com/ariya/phantomjs/issues/14458)). The `chromium-browser` will provide ES5 syntax support and enable testing for more libraries. This will be one of the foundational steps in the overall `ambari-web` upgrade plan.
This PR will be divided into two modules: `ambari-web` and `ambari-admin`. PhantomJS will be completely removed, and some failing tests will be fixed.
## How was this patch tested?
```bash
mvn -T 2C -am test -pl ambari-web -Dmaven.artifact.threads=10 -Drat.skip
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "mgucma (via GitHub)" <gi...@apache.org>.
mgucma commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2325223538
Have you tried, for example: Puppeteer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "mgucma (via GitHub)" <gi...@apache.org>.
mgucma commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2328022155
> @mgucma Try running the test command in the same environment without using Docker; you should be able to get error messages, or use the -X parameter.
@zRains
The biggest problem with tests for ambari server and I had to update junit to version 4.12.3. And now I am in the process of correcting tests.
My Pull Requet to Rocky 9 will not pass, but I need Ambari update for this system. I need to do migration from Centos 7 to Rocky 9.
Can you show me the way to make corrections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2328049368
@mgucma
1. Ambari itself is a Java and Python program, theoretically supporting all operating systems. However, Ambari includes two acceleration libraries (.c) in the Ambari agent, which leads to coupling with the operating system.
2. The big data components managed by Ambari have different levels of coupling with the operating system, depending on their implementation. So if you want Ambari to support Rocky 9, you can refer to this PR for Rocky 8:
https://github.com/apache/ambari/pull/3758/files
3. Because of this PR, I modified the Jenkinsfile, which will temporarily cause the project's CI/CD to fail, but this will be fixed quickly. So if you submit a PR, don't worry about the CI/CD issues caused by this PR.
The support for other big data components on Rocky 9 is controlled by the Apache Bigtop project. Additionally, I recommend that you first submit your code as a PR, so that some initial review and suggestions can be made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC merged PR #3809:
URL: https://github.com/apache/ambari/pull/3809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "zRains (via GitHub)" <gi...@apache.org>.
zRains commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2326201472
@mgucma Good idea, this is already in the planning stage, but it is currently limited by dependencies in the project, such as [brunch](https://brunch.io/). It will still take some time to handle compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "zRains (via GitHub)" <gi...@apache.org>.
zRains commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2326354877
@mgucma Try running the test command in the same environment without using Docker; you should be able to get error messages, or use the -X parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "zRains (via GitHub)" <gi...@apache.org>.
zRains commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2322894288
cc @JiaLiangC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "mgucma (via GitHub)" <gi...@apache.org>.
mgucma commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2326260178
> @mgucma Good idea, this is already in the planning stage, but it is currently limited by dependencies in the project, such as [brunch](https://brunch.io/). It will still take some time to handle compatibility issues.
@zRains Yes I know about it, I make rpm ambari under rocky 9 on docker. Without tests rpm is created. When I run tests it doesn't work and I can't find the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "zRains (via GitHub)" <gi...@apache.org>.
zRains commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2325452144
> Have you tried, for example: Puppeteer ?
No, just switched the test browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2330508317
Thanks for your great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser [ambari]
Posted by "mgucma (via GitHub)" <gi...@apache.org>.
mgucma commented on PR #3809:
URL: https://github.com/apache/ambari/pull/3809#issuecomment-2325866113
> > Have you tried, for example: Puppeteer ?
>
> No, just switched the test browser.
Recommended Node.js Versions:
Node.js 12.x to 16.x:
karma-chrome-launcher 3.2.0 works well with Node.js versions from 12.x to 16.x. These versions are also commonly supported by many other dependencies in the JavaScript ecosystem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org