[GitHub] [airflow] stelsemeyer-m60 commented on a diff in pull request #31008: Add startup_check_interval_seconds to PodManager's await_pod_start

["stelsemeyer-m60 (via GitHub)" <gi...@apache.org>]

stelsemeyer-m60 commented on code in PR #31008:
URL: https://github.com/apache/airflow/pull/31008#discussion_r1264586933


##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -595,6 +602,7 @@ def invoke_defer_method(self):
                 should_delete_pod=self.is_delete_operator_pod,
                 get_logs=self.get_logs,
                 startup_timeout=self.startup_timeout_seconds,
+                startup_check_interval=self.startup_check_interval_seconds,

Review Comment:
   Agree, it is not doing anything here. Will fix this.
   Moreover, I have no strong opinion in terms of deprecating `poll_interval` or renaming the new parameter `startup_check_interval_seconds/startup_timeoutcheck_interval_seconds` to `poll_interval` in the new implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org