You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Felix Lee <fe...@gmail.com> on 2011/07/10 07:54:06 UTC
Review Request: fix handling of caja=1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1060/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
JsServlet will strip out taming.js code unless you pass it caja=1.
1. r1131256 changed how RenderingGadgetRewriter constructs script URLs, and didn't add caja=1 when the gadget is cajoled.
2. r1140692 added a JsUri constructor that didn't copy the caja=1 flag.
This patch fixes those issues.
Diffs
-----
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1143612
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/JsUriManager.java 1143612
Diff: https://reviews.apache.org/r/1060/diff
Testing
-------
'mvn test' passes. samplecontainer renders cajoled gadgets.
Thanks,
Felix
Re: Review Request: fix handling of caja=1
Posted by Felix Lee <fe...@gmail.com>.
> On 2011-07-10 06:23:42, Paul Lindner wrote:
> > lgtm,
> >
> > would be nice if there were tests to catch this.. can be after this cl.
> >
> > Also add yourself to the committers in the top-level pom.xml
> >
ah, yeah, good point. will do.
- Felix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1060/#review1020
-----------------------------------------------------------
On 2011-07-10 05:54:06, Felix Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1060/
> -----------------------------------------------------------
>
> (Updated 2011-07-10 05:54:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> JsServlet will strip out taming.js code unless you pass it caja=1.
>
> 1. r1131256 changed how RenderingGadgetRewriter constructs script URLs, and didn't add caja=1 when the gadget is cajoled.
>
> 2. r1140692 added a JsUri constructor that didn't copy the caja=1 flag.
>
> This patch fixes those issues.
>
>
> Diffs
> -----
>
> /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1143612
> /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/JsUriManager.java 1143612
>
> Diff: https://reviews.apache.org/r/1060/diff
>
>
> Testing
> -------
>
> 'mvn test' passes. samplecontainer renders cajoled gadgets.
>
>
> Thanks,
>
> Felix
>
>
Re: Review Request: fix handling of caja=1
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1060/#review1020
-----------------------------------------------------------
Ship it!
lgtm,
would be nice if there were tests to catch this.. can be after this cl.
Also add yourself to the committers in the top-level pom.xml
- Paul
On 2011-07-10 05:54:06, Felix Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1060/
> -----------------------------------------------------------
>
> (Updated 2011-07-10 05:54:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> JsServlet will strip out taming.js code unless you pass it caja=1.
>
> 1. r1131256 changed how RenderingGadgetRewriter constructs script URLs, and didn't add caja=1 when the gadget is cajoled.
>
> 2. r1140692 added a JsUri constructor that didn't copy the caja=1 flag.
>
> This patch fixes those issues.
>
>
> Diffs
> -----
>
> /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1143612
> /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/JsUriManager.java 1143612
>
> Diff: https://reviews.apache.org/r/1060/diff
>
>
> Testing
> -------
>
> 'mvn test' passes. samplecontainer renders cajoled gadgets.
>
>
> Thanks,
>
> Felix
>
>