You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/06 03:28:43 UTC
[GitHub] [zookeeper] Oliverwqcwrw commented on a diff in pull request #1849: fix modifier order
Oliverwqcwrw commented on code in PR #1849:
URL: https://github.com/apache/zookeeper/pull/1849#discussion_r843426787
##########
zookeeper-contrib/zookeeper-contrib-loggraph/src/main/java/org/apache/zookeeper/graph/servlets/JsonServlet.java:
##########
@@ -30,7 +30,7 @@
import java.util.Map;
-abstract public class JsonServlet extends HttpServlet {
+public abstract class JsonServlet extends HttpServlet {
abstract String handleRequest(JsonRequest request) throws Exception;
Review Comment:
I think we should follow the Java specification, Modifiers should be declared in the correct order.
> The Java Language Specification recommends listing modifiers in the following order:
Annotations
public
protected
private
abstract
static
final
transient
volatile
synchronized
native
default
strictfp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org