You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2012/09/06 16:25:07 UTC
[jira] [Created] (OAK-292) Use Guava preconditions instead of
asserts to enforce contract
Marcel Reutegger created OAK-292:
------------------------------------
Summary: Use Guava preconditions instead of asserts to enforce contract
Key: OAK-292
URL: https://issues.apache.org/jira/browse/OAK-292
Project: Jackrabbit Oak
Issue Type: Improvement
Components: core
Reporter: Marcel Reutegger
Priority: Minor
Assertions shouldn't be used to enforce a contract. See discussion:
http://jackrabbit.markmail.org/thread/ji6ojjt6z3ztym2y
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-292) Use Guava preconditions instead of
asserts to enforce contract
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger resolved OAK-292.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.5
Patch committed in revision: 1382675
> Use Guava preconditions instead of asserts to enforce contract
> --------------------------------------------------------------
>
> Key: OAK-292
> URL: https://issues.apache.org/jira/browse/OAK-292
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 0.5
>
> Attachments: OAK-292.patch
>
>
> Assertions shouldn't be used to enforce a contract. See discussion:
> http://jackrabbit.markmail.org/thread/ji6ojjt6z3ztym2y
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-292) Use Guava preconditions instead of
asserts to enforce contract
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated OAK-292:
---------------------------------
Attachment: OAK-292.patch
Proposed changes.
I'm a bit undecided what to do with MemoryNodeState constructor.
It might be too expensive to always perform the disjoint check.
> Use Guava preconditions instead of asserts to enforce contract
> --------------------------------------------------------------
>
> Key: OAK-292
> URL: https://issues.apache.org/jira/browse/OAK-292
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Attachments: OAK-292.patch
>
>
> Assertions shouldn't be used to enforce a contract. See discussion:
> http://jackrabbit.markmail.org/thread/ji6ojjt6z3ztym2y
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OAK-292) Use Guava preconditions instead of
asserts to enforce contract
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger reassigned OAK-292:
------------------------------------
Assignee: Marcel Reutegger
> Use Guava preconditions instead of asserts to enforce contract
> --------------------------------------------------------------
>
> Key: OAK-292
> URL: https://issues.apache.org/jira/browse/OAK-292
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
>
> Assertions shouldn't be used to enforce a contract. See discussion:
> http://jackrabbit.markmail.org/thread/ji6ojjt6z3ztym2y
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-292) Use Guava preconditions instead of
asserts to enforce contract
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449996#comment-13449996 ]
Michael Dürig commented on OAK-292:
-----------------------------------
The patch looks good to me. Thanks for finding all this.
> Use Guava preconditions instead of asserts to enforce contract
> --------------------------------------------------------------
>
> Key: OAK-292
> URL: https://issues.apache.org/jira/browse/OAK-292
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Attachments: OAK-292.patch
>
>
> Assertions shouldn't be used to enforce a contract. See discussion:
> http://jackrabbit.markmail.org/thread/ji6ojjt6z3ztym2y
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira