You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/07/31 22:15:08 UTC

[Impala-ASF-CR] IMPALA-7317: comment on long lines and whitespace

Hello Philip Zeyliger, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11085

to look at the new patch set (#4).

Change subject: IMPALA-7317: comment on long lines and whitespace
......................................................................

IMPALA-7317: comment on long lines and whitespace

Add some basic formatting checks that can be implemented
easily by parsing the diff line-by-line. These are applied
to Java, Python, C++, shell and thrift source files with
some exclusions.

Adds a --dryrun option that does not try to post back the
comments to gerrit.

Remove the option to specify a git revision since flake8-diff doesn't
work correctly when run on source that isn't checked out.

Testing:
Added some violations to this code change that will be
fixed before merging.

Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2
---
M be/src/benchmarks/bloom-filter-benchmark.cc
M be/src/kudu/util/website_util.h
M bin/jenkins/critique-gerrit-review.py
3 files changed, 95 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/11085/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2
Gerrit-Change-Number: 11085
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>