You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2024/12/11 14:43:34 UTC
[PR] Don't let `test` depend on `shadowJar` [polaris]
snazy opened a new pull request, #535:
URL: https://github.com/apache/polaris/pull/535
The `test` task for modules producing a `shadowJar` artifact currently depend on the `shadowJar` task. This isn't necessary to run the tests.
This change removes the dependency of `test` on that task (via `jar`), letting tests in affected modules start much faster, because `shadowJar` isn't running.
Also removing related duplicated configurations in `polaris-dropwizard-service`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't let `test` depend on `shadowJar` [polaris]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on code in PR #535:
URL: https://github.com/apache/polaris/pull/535#discussion_r1880419178
##########
dropwizard/service/build.gradle.kts:
##########
@@ -160,12 +160,7 @@ tasks.register<Jar>("testJar") {
val shadowJar =
tasks.named<ShadowJar>("shadowJar") {
- manifest {
- attributes["Main-Class"] = "org.apache.polaris.service.dropwizard.PolarisApplication"
Review Comment:
Are these changes related? Looks like you fixed it above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't let `test` depend on `shadowJar` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #535:
URL: https://github.com/apache/polaris/pull/535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org