[GitHub] williaster commented on a change in pull request #5549: Add additional heatmap schemas

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5549: Add additional heatmap schemas
URL: https://github.com/apache/incubator-superset/pull/5549#discussion_r209030104
 
 

 ##########
 File path: superset/assets/src/explore/controls.jsx
 ##########
 @@ -324,6 +324,40 @@ export const controls = {
       ['red_yellow_blue', 'red/yellowish/blue'],
       ['brown_white_green', 'brown/white/green'],
       ['purple_white_green', 'purple/white/green'],
+      ['schemeBrBG', 'd3BrBG'],
 
 Review comment:
   can you please make these more human readable? non-power users are not going to have any idea what `BrBG` means

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org