[GitHub] [ozone] errose28 commented on a diff in pull request #3288: HDDS-6566. [Multi-Tenant] Fix a permission check bug that prevents non-delegated admins from assigning/revoking users to/from the tenant

[GitBox <gi...@apache.org>]

errose28 commented on code in PR #3288:
URL: https://github.com/apache/ozone/pull/3288#discussion_r849803987


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneTenantShell.java:
##########
@@ -816,6 +818,22 @@ public void testTenantSetSecret() throws IOException, InterruptedException {
       return null;
     });
 
+    // Assigning/revoking user accessIds should work for a non-delegated admin

Review Comment:
   I think we should split this off into its own test method. In that method, we can have a delegated and non-delegated admin. For each admin operation (add/revoke user, set secret, add/revoke admin) we try it as the delegated and non-delegated admin, and assert they pass or fail as expected. This should cover the full matrix of possible admin operations to admin type combinations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org