You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2007/08/27 00:31:32 UTC
[jira] Created: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Switching locale doesn't change already rendered feedback messages' language
----------------------------------------------------------------------------
Key: WICKET-891
URL: https://issues.apache.org/jira/browse/WICKET-891
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.0-beta3, 1.3.0-beta4
Reporter: Martijn Dashorst
Fix For: 1.3.0-beta4
It seems that the first localized feedback message is used to render, regardless of the session's locale.
Test case:
FormInput example:
- select Thai language
- type 'a' into an integer field, for instance the multiplication example
- press submit
- note the thai feedback message
- change Language to english
- type 'a' into an integer field, for instance the multiplication example
- press submit
- note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645274#action_12645274 ]
Brill Pappin commented on WICKET-891:
-------------------------------------
What version is the fix in?
I'm still having this or a very similar issue in 1.4-SNAPSHOT as of November 5, 2008
It looks as if the local is not being updated when changed on the client side.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta3
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-891.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.3.0-beta4)
1.3.0-beta3
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta3
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645283#action_12645283 ]
Igor Vaynberg commented on WICKET-891:
--------------------------------------
> No, what module am I looking for to run this test?
huh? see the description of this issue for a testcase i tried
> in general I'm getting unexpected behavior from locale resources but until I can dig further I can't define whats causing them.
right. that is not very helpful without a testcase
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta3
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522897 ]
Matej Knopp commented on WICKET-891:
------------------------------------
Should be fixed now.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-891) Switching locale doesn't
change already rendered feedback messages' language
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645274#action_12645274 ]
brill edited comment on WICKET-891 at 11/5/08 10:06 AM:
---------------------------------------------------------------
What version is the fix in?
I'm still having this or a very similar issue in 1.4-SNAPSHOT as of November 5, 2008
It looks as if the locale is not being updated when changed on the client side.
was (Author: brill):
What version is the fix in?
I'm still having this or a very similar issue in 1.4-SNAPSHOT as of November 5, 2008
It looks as if the local is not being updated when changed on the client side.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta3
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645280#action_12645280 ]
Brill Pappin commented on WICKET-891:
-------------------------------------
No, what module am I looking for to run this test?
in general I'm getting unexpected behavior from locale resources but until I can dig further I can't define whats causing them.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta3
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522893 ]
Eelco Hillenius commented on WICKET-891:
----------------------------------------
It is actually more serious than just switching sessions. If you loaded a message in say Thai for *any* session, that message will be used for all sessions after that, regardless of the locale for that session. This means localization is completely broken. We also have to test whether this applies only to properties/ message bundles or to all resources.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Fix For: 1.3.0-beta4
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522894 ]
Eelco Hillenius commented on WICKET-891:
----------------------------------------
patches unit tests PropertiesTest and ValidatorPropertiesTest to prove the failures.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-891) Switching locale doesn't
change already rendered feedback messages' language
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522894 ]
ehillenius edited comment on WICKET-891 at 8/26/07 3:37 PM:
-----------------------------------------------------------------
patched unit tests PropertiesTest and ValidatorPropertiesTest to prove the failures.
was (Author: ehillenius):
patches unit tests PropertiesTest and ValidatorPropertiesTest to prove the failures.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-891:
-----------------------------------
Priority: Critical (was: Major)
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-891) Switching locale doesn't change
already rendered feedback messages' language
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645279#action_12645279 ]
Igor Vaynberg commented on WICKET-891:
--------------------------------------
do you have a quickstart/testcase? the testcase outlined in the summary of this issue works fine for me.
> Switching locale doesn't change already rendered feedback messages' language
> ----------------------------------------------------------------------------
>
> Key: WICKET-891
> URL: https://issues.apache.org/jira/browse/WICKET-891
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4
> Reporter: Martijn Dashorst
> Priority: Critical
> Fix For: 1.3.0-beta3
>
>
> It seems that the first localized feedback message is used to render, regardless of the session's locale.
> Test case:
> FormInput example:
> - select Thai language
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note the thai feedback message
> - change Language to english
> - type 'a' into an integer field, for instance the multiplication example
> - press submit
> - note that the language of the feedback message hasn't changed to english, but remains thai.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.